Issue 9429014: Encyptor file changes.

Issue 9429014: Encyptor file changes. (Closed)

Created:
8 years, 10 months ago by Ramya

Modified:
8 years, 10 months ago

Reviewers:
Yaron, jam

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Encyptor file changes. Rename encryptor_linux.cc into encryptor_posix.cc and exclude from Mac build. BUG=113487 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123154

Patch Set 2 : Fixing the alphabetical order #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -139 lines)			Patch
D	chrome/browser/password_manager/encryptor_linux.cc	View		1 chunk	+0 lines, -139 lines	0 comments	Download
A +	chrome/browser/password_manager/encryptor_posix.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Yaron

lgtm +John for committer/owner stamp https://chromiumcodereview.appspot.com/9429014/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://chromiumcodereview.appspot.com/9429014/diff/1/chrome/chrome_browser.gypi#newcode4695 chrome/chrome_browser.gypi:4695: 'browser/password_manager/encryptor_posix.cc', Nit: alphabetical sort

8 years, 10 months ago (2012-02-21 22:56:34 UTC) #2

Ramya

Thanks. Made the change. https://chromiumcodereview.appspot.com/9429014/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://chromiumcodereview.appspot.com/9429014/diff/1/chrome/chrome_browser.gypi#newcode4695 chrome/chrome_browser.gypi:4695: 'browser/password_manager/encryptor_posix.cc', On 2012/02/21 22:56:34, Yaron ...

8 years, 10 months ago (2012-02-21 23:01:56 UTC) #3

jam

On 2012/02/21 22:56:34, Yaron wrote: > lgtm > > +John for committer/owner stamp what owner ...

8 years, 10 months ago (2012-02-22 02:29:24 UTC) #4

Yaron

On 2012/02/22 02:29:24, John Abd-El-Malek wrote: > On 2012/02/21 22:56:34, Yaron wrote: > > lgtm ...

8 years, 10 months ago (2012-02-22 02:39:26 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cramya@chromium.org/9429014/3001

8 years, 10 months ago (2012-02-22 22:47:59 UTC) #6

Change committed as 123154

Expand Messages | Collapse Messages