Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2177)

Unified Diff: chrome/browser/ui/webui/extensions/extension_icon_source.h

Issue 9428025: Add support for multiple icon sizes for Mac platform apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comment Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_icon_source.h
diff --git a/chrome/browser/ui/webui/extensions/extension_icon_source.h b/chrome/browser/ui/webui/extensions/extension_icon_source.h
index c17c0186882de9d6b0b26803cc210bcb0107fbaa..4c67e8d58259cba19b4d098f70f0d47be58db6e8 100644
--- a/chrome/browser/ui/webui/extensions/extension_icon_source.h
+++ b/chrome/browser/ui/webui/extensions/extension_icon_source.h
@@ -90,7 +90,7 @@ class ExtensionIconSource : public ChromeURLDataManager::DataSource,
// Performs any remaining transformations (like desaturating the |image|),
// then returns the |image| to the client and clears up any temporary data
// associated with the |request_id|.
- void FinalizeImage(SkBitmap* image, int request_id);
+ void FinalizeImage(const SkBitmap* image, int request_id);
// Loads the default image for |request_id| and returns to the client.
void LoadDefaultImage(int request_id);
@@ -114,8 +114,8 @@ class ExtensionIconSource : public ChromeURLDataManager::DataSource,
history::FaviconData favicon);
// ImageLoadingTracker::Observer
- virtual void OnImageLoaded(SkBitmap* image,
- const ExtensionResource& resource,
+ virtual void OnImageLoaded(const gfx::Image* image,
+ const std::string& extension_id,
int id) OVERRIDE;
// Called when the extension doesn't have an icon. We fall back to multiple

Powered by Google App Engine
This is Rietveld 408576698