Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6341)

Unified Diff: chrome/browser/ui/views/infobars/extension_infobar.cc

Issue 9428025: Add support for multiple icon sizes for Mac platform apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comment Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/infobars/extension_infobar.cc
diff --git a/chrome/browser/ui/views/infobars/extension_infobar.cc b/chrome/browser/ui/views/infobars/extension_infobar.cc
index 343bbd1720f99eeb7ef2bb4bbc689a6fb2724668..91bf318cb3ed932ba6aed0ff9fa7c56c1595a04d 100644
--- a/chrome/browser/ui/views/infobars/extension_infobar.cc
+++ b/chrome/browser/ui/views/infobars/extension_infobar.cc
@@ -16,6 +16,7 @@
#include "ui/base/animation/slide_animation.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/gfx/canvas_skia.h"
+#include "ui/gfx/image/image.h"
#include "ui/views/controls/button/menu_button.h"
#include "ui/views/controls/menu/menu_item_view.h"
#include "ui/views/widget/widget.h"
@@ -97,7 +98,7 @@ void ExtensionInfoBar::ViewHierarchyChanged(bool is_add,
tracker_.LoadImage(extension, icon_resource,
gfx::Size(image_size, image_size), ImageLoadingTracker::DONT_CACHE);
} else {
- OnImageLoaded(NULL, icon_resource, 0);
+ OnImageLoaded(NULL, std::string(), 0);
}
}
@@ -105,17 +106,19 @@ int ExtensionInfoBar::ContentMinimumWidth() const {
return menu_->GetPreferredSize().width() + kMenuHorizontalMargin;
}
-void ExtensionInfoBar::OnImageLoaded(SkBitmap* image,
- const ExtensionResource& resource,
+void ExtensionInfoBar::OnImageLoaded(const gfx::Image* image,
+ const std::string& extension_id,
int index) {
if (!GetDelegate())
return; // The delegate can go away while we asynchronously load images.
- SkBitmap* icon = image;
+ const SkBitmap* icon = NULL;
// Fall back on the default extension icon on failure.
ResourceBundle& rb = ResourceBundle::GetSharedInstance();
- if (!image || image->empty())
+ if (!image || image->IsEmpty())
icon = rb.GetBitmapNamed(IDR_EXTENSIONS_SECTION);
+ else
+ icon = image->AsSkBitmap();
SkBitmap* drop_image = rb.GetBitmapNamed(IDR_APP_DROPARROW);

Powered by Google App Engine
This is Rietveld 408576698