Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8051)

Unified Diff: chrome/browser/ui/views/browser_actions_container.cc

Issue 9428025: Add support for multiple icon sizes for Mac platform apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comment Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/browser_actions_container.cc
diff --git a/chrome/browser/ui/views/browser_actions_container.cc b/chrome/browser/ui/views/browser_actions_container.cc
index 7158c587e0586e23b050908ff9ead8ee9e79360c..bac2747bd17c661a973f0bf3778a2174bef8ad4a 100644
--- a/chrome/browser/ui/views/browser_actions_container.cc
+++ b/chrome/browser/ui/views/browser_actions_container.cc
@@ -42,6 +42,7 @@
#include "ui/base/theme_provider.h"
#include "ui/gfx/canvas.h"
#include "ui/gfx/canvas_skia.h"
+#include "ui/gfx/image/image.h"
#include "ui/views/controls/button/menu_button.h"
#include "ui/views/controls/button/text_button.h"
#include "ui/views/controls/menu/menu_item_view.h"
@@ -118,11 +119,11 @@ void BrowserActionButton::ButtonPressed(views::Button* sender,
panel_->OnBrowserActionExecuted(this, false);
}
-void BrowserActionButton::OnImageLoaded(SkBitmap* image,
- const ExtensionResource& resource,
+void BrowserActionButton::OnImageLoaded(const gfx::Image* image,
+ const std::string& extension_id,
int index) {
if (image)
- default_icon_ = *image;
+ default_icon_ = *image->ToSkBitmap();
// Call back to UpdateState() because a more specific icon might have been set
// while the load was outstanding.

Powered by Google App Engine
This is Rietveld 408576698