Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1488)

Unified Diff: chrome/browser/ui/views/aura/launcher/launcher_icon_loader.cc

Issue 9428025: Add support for multiple icon sizes for Mac platform apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comment Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/aura/launcher/launcher_icon_loader.cc
diff --git a/chrome/browser/ui/views/aura/launcher/launcher_icon_loader.cc b/chrome/browser/ui/views/aura/launcher/launcher_icon_loader.cc
index 20137a8b9bcc75fa9a749893adfe60df374a5e32..5ce46773bded9819432967d3e511c1ea2da9b8a8 100644
--- a/chrome/browser/ui/views/aura/launcher/launcher_icon_loader.cc
+++ b/chrome/browser/ui/views/aura/launcher/launcher_icon_loader.cc
@@ -10,6 +10,7 @@
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_resource.h"
#include "content/public/browser/web_contents.h"
+#include "ui/gfx/image/image.h"
LauncherIconLoader::LauncherIconLoader(Profile* profile,
LauncherUpdater* icon_updater)
@@ -47,8 +48,8 @@ void LauncherIconLoader::FetchImage(TabContentsWrapper* tab) {
ImageLoadingTracker::CACHE);
}
-void LauncherIconLoader::OnImageLoaded(SkBitmap* image,
- const ExtensionResource& resource,
+void LauncherIconLoader::OnImageLoaded(const gfx::Image* image,
+ const std::string& extension_id,
int index) {
ImageLoaderIDToTabMap::iterator i = image_loader_id_to_tab_map_.find(index);
if (i == image_loader_id_to_tab_map_.end())
@@ -56,7 +57,7 @@ void LauncherIconLoader::OnImageLoaded(SkBitmap* image,
TabContentsWrapper* tab = i->second;
image_loader_id_to_tab_map_.erase(i);
- icon_updater_->SetAppImage(tab, image);
+ icon_updater_->SetAppImage(tab, image ? image->ToSkBitmap() : NULL);
}
void LauncherIconLoader::RemoveFromImageLoaderMap(TabContentsWrapper* tab) {

Powered by Google App Engine
This is Rietveld 408576698