Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6376)

Unified Diff: chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc

Issue 9428025: Add support for multiple icon sizes for Mac platform apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc
diff --git a/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc b/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc
index 5ae03d64722768f2825c8efb682c4fb9f25086bf..f893d429a0854822524b99964f921b727789aaa3 100644
--- a/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc
+++ b/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc
@@ -39,6 +39,7 @@
#include "ui/base/gtk/gtk_compat.h"
#include "ui/gfx/canvas_skia_paint.h"
#include "ui/gfx/gtk_util.h"
+#include "ui/gfx/image/image.h"
namespace {
@@ -160,11 +161,12 @@ class BrowserActionButton : public content::NotificationObserver,
}
// ImageLoadingTracker::Observer implementation.
- void OnImageLoaded(SkBitmap* image, const ExtensionResource& resource,
- int index) {
+ void OnImageLoaded(const gfx::Image* image,
+ const std::string& extension_id,
+ int index) OVERRIDE {
if (image) {
- default_skbitmap_ = *image;
- default_icon_ = gfx::GdkPixbufFromSkBitmap(image);
+ default_skbitmap_ = image->ToSkBitmap();
Mihai Parparita -not on Chrome 2012/02/23 00:19:41 Seems like this should be *image->ToSkBitmap()
sail 2012/02/23 02:54:27 Done.
+ default_icon_ = image->ToGdkPixbuf();
}
UpdateState();
}

Powered by Google App Engine
This is Rietveld 408576698