Add support for multiple icon sizes for Mac platform apps

chrome/browser/web_applications/web_app_mac_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/web_applications/web_app_mac.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/file_util.h"
 #include "base/mac/foundation_util.h"
@@ skipping 71 matching lines @@
       .WillRepeatedly(Return(FilePath("/non-existant/path/")));
   EXPECT_FALSE(shortcut_creator.CreateShortcut());
 }
 
 TEST(WebAppShortcutCreatorTest, UpdateIcon) {
   ScopedTempDir scoped_temp_dir;
   ASSERT_TRUE(scoped_temp_dir.CreateUniqueTempDir());
   FilePath dst_path = scoped_temp_dir.path();
 
   ShellIntegration::ShortcutInfo info = GetShortcutInfo();
-  info.favicon = *ui::ResourceBundle::GetSharedInstance().GetImageNamed(
-      IDR_PRODUCT_LOGO_32).ToSkBitmap();
+  info.favicon = ui::ResourceBundle::GetSharedInstance().GetImageNamed(
+      IDR_PRODUCT_LOGO_32);

[jeremy, 2012/03/01 10:54:39]

How hard would it be to add a test for a bitmap for which
AddBitmapImageRepToIconFamily() fails?

[sail, 2012/03/04 04:59:56]

There wasn't an easy way to do this. I'll look into this for a second CL.

   WebAppShortcutCreatorMock shortcut_creator(info);
 
   shortcut_creator.UpdateIcon(dst_path);
   FilePath icon_path =
       dst_path.Append("Contents").Append("Resources").Append("app.icns");
 
   scoped_nsobject<NSImage> image([[NSImage alloc] initWithContentsOfFile:
       base::mac::FilePathToNSString(icon_path)]);
   EXPECT_TRUE(image);
-  EXPECT_EQ(info.favicon.width(), [image size].width);
-  EXPECT_EQ(info.favicon.height(), [image size].height);
+  EXPECT_EQ(info.favicon.ToSkBitmap()->width(), [image size].width);
+  EXPECT_EQ(info.favicon.ToSkBitmap()->height(), [image size].height);
 }
 
 }  // namespace web_app