chrome/browser/extensions/extension_tabs_apitest.cc - Issue 9428018: Create BaseWindow and ExtensionWindowWrapper for extension API access to Panels

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tabs_apitest.cc

Issue 9428018: Create BaseWindow and ExtensionWindowWrapper for extension API access to Panels (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Address comments, rename -> ExtensionWindowController Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/browser_extension_window_controller.cc ('K') | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/browser/extensions/extension_tabs_module.cc » ('j') | chrome/browser/extensions/extension_tabs_module.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_tabs_apitest.cc

diff --git a/chrome/browser/extensions/extension_tabs_apitest.cc b/chrome/browser/extensions/extension_tabs_apitest.cc

index ecb84ec9e6252b78cde9dca7dc09b27bb0d3dfab..5895ae2bbc5208c294a08ebf79cbac7723fb4a94 100644

--- a/chrome/browser/extensions/extension_tabs_apitest.cc

+++ b/chrome/browser/extensions/extension_tabs_apitest.cc

@@ -20,8 +20,8 @@

#endif

// Window resizes are not completed by the time the callback happens,

-// so these tests fail on linux. http://crbug.com/72369

-#if defined(OS_LINUX)

+// so these tests fail on linux/gtk. http://crbug.com/72369

+#if defined(OS_LINUX) && !defined(USE_AURA)

#define MAYBE_FocusWindowDoesNotExitFullscreen \

DISABLED_FocusWindowDoesNotExitFullscreen

#define MAYBE_UpdateWindowSizeExitsFullscreen \