chrome/browser/extensions/extension_browser_event_router.cc - Issue 9428018: Create BaseWindow and ExtensionWindowWrapper for extension API access to Panels

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_browser_event_router.cc

Issue 9428018: Create BaseWindow and ExtensionWindowWrapper for extension API access to Panels (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Address comments, rename -> ExtensionWindowController Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/browser_extension_window_controller.cc ('K') | « chrome/browser/extensions/browser_extension_window_controller.cc ('k') | chrome/browser/extensions/extension_tab_util.h » ('j') | chrome/browser/extensions/extension_tabs_module.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_browser_event_router.cc

diff --git a/chrome/browser/extensions/extension_browser_event_router.cc b/chrome/browser/extensions/extension_browser_event_router.cc

index aded37d67262f840de4fe2732170f2bf590348b2..50d74f70dc9121647be1981efc0073762adc8dc5 100644

--- a/chrome/browser/extensions/extension_browser_event_router.cc

+++ b/chrome/browser/extensions/extension_browser_event_router.cc

@@ -11,6 +11,7 @@

#include "chrome/browser/extensions/extension_page_actions_module_constants.h"

#include "chrome/browser/extensions/extension_tab_util.h"

#include "chrome/browser/extensions/extension_tabs_module_constants.h"

+#include "chrome/browser/extensions/extension_window_controller.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/tabs/tab_strip_model.h"

#include "chrome/browser/ui/browser.h"

@@ -171,8 +172,9 @@ void ExtensionBrowserEventRouter::UnregisterForTabNotifications(

void ExtensionBrowserEventRouter::OnBrowserWindowReady(const Browser* browser) {

ListValue args;

- DictionaryValue* window_dictionary = ExtensionTabUtil::CreateWindowValue(

- browser, false);

+ DCHECK(browser->extension_window_controller());

+ DictionaryValue* window_dictionary =

+ browser->extension_window_controller()->CreateWindowValue();

args.Append(window_dictionary);

std::string json_args;