chrome/browser/infobars/infobar_extension_api.cc - Issue 9428018: Create BaseWindow and ExtensionWindowWrapper for extension API access to Panels

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/infobars/infobar_extension_api.cc

Issue 9428018: Create BaseWindow and ExtensionWindowWrapper for extension API access to Panels (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Address comments. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_window_list.h ('K') | « chrome/browser/extensions/extension_window_list.cc ('k') | chrome/browser/ui/base_window.h » ('j') | chrome/browser/ui/browser_window.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/infobars/infobar_extension_api.cc

diff --git a/chrome/browser/infobars/infobar_extension_api.cc b/chrome/browser/infobars/infobar_extension_api.cc

index 359480fa92611cf8e489147080eabe62f394ab25..8e6625b44de3166902dd277190f7b42d46331a17 100644

--- a/chrome/browser/infobars/infobar_extension_api.cc

+++ b/chrome/browser/infobars/infobar_extension_api.cc

@@ -11,6 +11,7 @@

#include "chrome/browser/extensions/extension_infobar_delegate.h"

#include "chrome/browser/extensions/extension_tab_util.h"

#include "chrome/browser/extensions/extension_tabs_module_constants.h"

+#include "chrome/browser/extensions/extension_window_controller.h"

#include "chrome/browser/infobars/infobar_tab_helper.h"

#include "chrome/browser/tab_contents/confirm_infobar_delegate.h"

#include "chrome/browser/ui/browser.h"

@@ -70,7 +71,8 @@ bool ShowInfoBarFunction::RunImpl() {

GetExtension(), url, height));

// TODO(finnur): Return the actual DOMWindow object. Bug 26463.

- result_.reset(ExtensionTabUtil::CreateWindowValue(browser, false));

+ DCHECK(browser->extension_window_controller());

+ result_.reset(browser->extension_window_controller()->CreateWindowValue());

return true;

}