Add functions to expand PostDelayedTask interface.

Add functions to expand PostDelayedTask interface.

These functions add TimeDelta interfaces in addition to the int ms interfaces,
which will be removed at a later date.

BUG=108171
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123683

[Ted Vessenes, 2012-02-21 05:20:18]

jar: Please review base/*
sergeyu: Please review remoting/*
rdsmith: Please review content/*

The PostDelayedTask interface is getting changed to use base::TimeDelta instead
of int64 values in millisecond units.  I'm adding new interface functions now so
uses of this code can get converted.  Once those conversions are done, the old
interfaces will be removed.

[Randy Smith (Not in Mondays), 2012-02-21 13:28:50]

@tedv: My presence in content/public/browser/OWNERS is a for the download
interfaces only.  jam@ should review new interface additions.

[Ted Vessenes, 2012-02-21 15:54:42]

On 2012/02/21 13:28:50, rdsmith wrote:
> @tedv: My presence in content/public/browser/OWNERS is a for the download
> interfaces only.  jam@ should review new interface additions.

Apologies; I'll remove you from the reviewer list.

[jar (doing other things), 2012-02-21 18:21:31]

LGTM (for base)

[Sergey Ulanov, 2012-02-21 18:26:35]

remoting/* lgtm

[commit-bot: I haz the power, 2012-02-21 20:52:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9427023/1

[commit-bot: I haz the power, 2012-02-21 20:52:19]

Presubmit check for 9427023-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for: content/public/browser/browser_thread.h

Presubmit checks took 1.1s to calculate.

[Avi (use Gerrit), 2012-02-21 20:55:43]

content owner LGTM

[commit-bot: I haz the power, 2012-02-21 22:22:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9427023/1

[commit-bot: I haz the power, 2012-02-21 22:51:11]

Try job failure for 9427023-1 (retry) on linux_clang for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2012-02-22 00:52:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9427023/1

[commit-bot: I haz the power, 2012-02-22 01:20:31]

Try job failure for 9427023-1 (retry) on linux_clang for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[Ted Vessenes, 2012-02-23 18:22:23]

Just as a heads up, these errors are caused by abstract base classes having
interfaces defined that weren't implemented in some of the derived classes.  I'm
working on defining these functions but am running into linker problems. 
Hopefully things will be moving along shortly though.

[Ted Vessenes, 2012-02-24 19:16:24]

Alright, I had to add a few more function definitions to code in base/* and
content/*.  Can you please review these before I send them out?

[jar (doing other things), 2012-02-25 02:00:22]

http://codereview.chromium.org/9427023/diff/12001/content/browser/browser_thr...
File content/browser/browser_thread_impl.cc (right):

http://codereview.chromium.org/9427023/diff/12001/content/browser/browser_thr...
content/browser/browser_thread_impl.cc:195: const base::Closure& task,
base::TimeDelta delay) OVERRIDE{
nits: space before the curly.  Probably one argument per line looks nicer (like
you did in line 209)

http://codereview.chromium.org/9427023/diff/12001/content/browser/browser_thr...
content/browser/browser_thread_impl.cc:299: identifier, from_here, task,
delay.InMilliseconds(), true);
I was a bit surprised you converted to ms here, and in line 328.

http://codereview.chromium.org/9427023/diff/12001/remoting/base/plugin_messag...
File remoting/base/plugin_message_loop_proxy.cc (right):

http://codereview.chromium.org/9427023/diff/12001/remoting/base/plugin_messag...
remoting/base/plugin_message_loop_proxy.cc:46: delay.InMilliseconds(),
Is this transition (to using TimeDelta) a future CL plan? .... or is there
another reason you stopped here? (Exhaustion?)

[Ted Vessenes, 2012-02-25 04:01:43]

I think I was worried about biting off too much conversation in a single CL, but
in retrospect you are right that this should be done here.

[Ted Vessenes, 2012-02-25 06:12:48]

Alright, converted more, though I stopped short of updating the full PPAPI
interface, as that seemed like a bit much.  Let me know what you think.

[jar (doing other things), 2012-02-25 18:14:27]

lgtm

[commit-bot: I haz the power, 2012-02-25 18:30:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9427023/18002

[commit-bot: I haz the power, 2012-02-25 18:58:29]

Try job failure for 9427023-18002 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-02-26 05:07:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9427023/12007

[commit-bot: I haz the power, 2012-02-26 08:17:40]

Change committed as 123683