Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 9427008: Make offline error page visible (Closed)

Created:
8 years, 10 months ago by Dmitry Polukhin
Modified:
8 years, 10 months ago
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Make offline error page visible The problem happened because the page used chrome:// to load local_strings.js but it failed because page itself is served from data URL that has no access to chrome://. Error in the log was "Not allowed to load local resource". Now local_strings.js is flatten and it fixes the issue. Also return timeout for showing offline error page. BUG=chromium-os:23792 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123029

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/chromeos/offline/offline_load_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/offline_load.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Dmitry Polukhin
8 years, 10 months ago (2012-02-20 11:36:15 UTC) #1
oshima
lgtm
8 years, 10 months ago (2012-02-21 18:07:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/9427008/1
8 years, 10 months ago (2012-02-21 19:25:55 UTC) #3
commit-bot: I haz the power
Presubmit check for 9427008-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-02-21 19:25:57 UTC) #4
Dmitry Polukhin
+ arv for OWNER review chrome/browser/resources/chromeos/offline_load.html
8 years, 10 months ago (2012-02-21 19:43:48 UTC) #5
Dmitry Polukhin
+ Nikita for OWNER review chrome/browser/resources/chromeos/offline_load.html
8 years, 10 months ago (2012-02-22 07:04:44 UTC) #6
Nikita (slow)
lgtm
8 years, 10 months ago (2012-02-22 10:32:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/9427008/1
8 years, 10 months ago (2012-02-22 10:36:27 UTC) #8
commit-bot: I haz the power
8 years, 10 months ago (2012-02-22 12:41:10 UTC) #9
Change committed as 123029

Powered by Google App Engine
This is Rietveld 408576698