Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Unified Diff: chrome/browser/download/download_browsertest.cc

Issue 9426029: Test file errors in downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged with parent Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_browsertest.cc
diff --git a/chrome/browser/download/download_browsertest.cc b/chrome/browser/download/download_browsertest.cc
index feca83348884b8ad83109cdbf7fece8976c5dfd2..15b288a54879a0e5e9957a72c545b9b4e31e569c 100644
--- a/chrome/browser/download/download_browsertest.cc
+++ b/chrome/browser/download/download_browsertest.cc
@@ -54,6 +54,7 @@
#include "content/public/browser/web_contents.h"
#include "content/public/common/context_menu_params.h"
#include "content/public/common/page_transition_types.h"
+#include "content/test/test_file_error_injector.h"
#include "net/base/net_util.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -304,6 +305,13 @@ class DownloadTest : public InProcessBrowserTest {
int download_items_shown; // Number of download items shown on the shelf.
};
+ struct FileErrorInjectInfo {
cbentzel 2012/02/24 02:25:12 Document this and fields.
ahendrickson 2012/02/24 22:48:39 Done.
+ DownloadInfo download_info;
+ FileOperationCode code;
+ int operation_index;
+ net::Error error_to_inject;
+ };
+
DownloadTest() {
EnableDOMAutomation();
}
@@ -739,6 +747,21 @@ class DownloadTest : public InProcessBrowserTest {
}
}
+ void DownloadInsertFileErrorCheckErrors(const FileErrorInjectInfo& info) {
+ // Do initial setup.
+ ASSERT_TRUE(InitialSetup(false));
+
+ // Set up file failures.
+ scoped_refptr<TestFileErrorInjector> injector(
+ TestFileErrorInjector::Create());
+ injector->InjectError(0, // First DownloadFile created.
+ info.code,
+ info.operation_index,
+ info.error_to_inject);
+
+ DownloadFileCheckErrors(info.download_info);
+ }
+
private:
// Location of the test data.
FilePath test_dir_;
@@ -2023,3 +2046,185 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadError400Navigate) {
ASSERT_TRUE(InitialSetup(false));
DownloadFileCheckErrors(download_info);
}
+
+IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadErrorFileNoSpaceOpenNavigate) {
+ FileErrorInjectInfo error_info = {
+ { "a_zip_file.zip",
+ DOWNLOAD_NAVIGATE,
+ DOWNLOAD_INTERRUPT_REASON_FILE_NO_SPACE,
+ 1
+ },
+ FILE_OPERATION_INITIALIZE,
+ 0,
+ net::ERR_FILE_NO_SPACE
+ };
+
+ DownloadInsertFileErrorCheckErrors(error_info);
+}
+
+IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadErrorFileNoSpaceOpenDirect) {
+ FileErrorInjectInfo error_info = {
+ { "a_zip_file.zip",
+ DOWNLOAD_DIRECT,
+ DOWNLOAD_INTERRUPT_REASON_FILE_NO_SPACE,
+ 1
+ },
+ FILE_OPERATION_INITIALIZE,
+ 0,
+ net::ERR_FILE_NO_SPACE
+ };
+
+ DownloadInsertFileErrorCheckErrors(error_info);
+}
+
+IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadErrorFileNoSpaceWriteNavigate) {
+ FileErrorInjectInfo error_info = {
+ { "a_zip_file.zip",
+ DOWNLOAD_NAVIGATE,
+ DOWNLOAD_INTERRUPT_REASON_FILE_NO_SPACE,
+ 1
+ },
+ FILE_OPERATION_WRITE,
+ 0,
+ net::ERR_FILE_NO_SPACE
+ };
+
+ DownloadInsertFileErrorCheckErrors(error_info);
+}
+
+IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadErrorFileNoSpaceWriteDirect) {
+ FileErrorInjectInfo error_info = {
+ { "a_zip_file.zip",
+ DOWNLOAD_DIRECT,
+ DOWNLOAD_INTERRUPT_REASON_FILE_NO_SPACE,
+ 1
+ },
+ FILE_OPERATION_WRITE,
+ 0,
+ net::ERR_FILE_NO_SPACE
+ };
+
+ DownloadInsertFileErrorCheckErrors(error_info);
+}
+
+IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadErrorFileFailedOpenNavigate) {
+ FileErrorInjectInfo error_info = {
+ { "a_zip_file.zip",
+ DOWNLOAD_NAVIGATE,
+ DOWNLOAD_INTERRUPT_REASON_FILE_FAILED,
+ 1
+ },
+ FILE_OPERATION_INITIALIZE,
+ 0,
+ net::ERR_FAILED
+ };
+
+ DownloadInsertFileErrorCheckErrors(error_info);
+}
+
+IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadErrorFileFailedOpenDirect) {
+ FileErrorInjectInfo error_info = {
+ { "a_zip_file.zip",
+ DOWNLOAD_DIRECT,
+ DOWNLOAD_INTERRUPT_REASON_FILE_FAILED,
+ 1
+ },
+ FILE_OPERATION_INITIALIZE,
+ 0,
+ net::ERR_FAILED
+ };
+
+ DownloadInsertFileErrorCheckErrors(error_info);
+}
+
+IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadErrorFileFailedWriteNavigate) {
+ FileErrorInjectInfo error_info = {
+ { "a_zip_file.zip",
+ DOWNLOAD_NAVIGATE,
+ DOWNLOAD_INTERRUPT_REASON_FILE_FAILED,
+ 1
+ },
+ FILE_OPERATION_WRITE,
+ 0,
+ net::ERR_FAILED
+ };
+
+ DownloadInsertFileErrorCheckErrors(error_info);
+}
+
+IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadErrorFileFailedWriteDirect) {
+ FileErrorInjectInfo error_info = {
+ { "a_zip_file.zip",
+ DOWNLOAD_DIRECT,
+ DOWNLOAD_INTERRUPT_REASON_FILE_FAILED,
+ 1
+ },
+ FILE_OPERATION_WRITE,
+ 0,
+ net::ERR_FAILED
+ };
+
+ DownloadInsertFileErrorCheckErrors(error_info);
+}
+
+IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadErrorFileNameTooLongOpenNavigate) {
+ FileErrorInjectInfo error_info = {
+ { "a_zip_file.zip",
+ DOWNLOAD_NAVIGATE,
+ DOWNLOAD_INTERRUPT_REASON_FILE_NAME_TOO_LONG,
+ 1
+ },
+ FILE_OPERATION_INITIALIZE,
+ 0,
+ net::ERR_FILE_PATH_TOO_LONG
+ };
+
+ DownloadInsertFileErrorCheckErrors(error_info);
+}
+
+IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadErrorFileNameTooLongOpenDirect) {
+ FileErrorInjectInfo error_info = {
+ { "a_zip_file.zip",
+ DOWNLOAD_DIRECT,
+ DOWNLOAD_INTERRUPT_REASON_FILE_NAME_TOO_LONG,
+ 1
+ },
+ FILE_OPERATION_INITIALIZE,
+ 0,
+ net::ERR_FILE_PATH_TOO_LONG
+ };
+
+ DownloadInsertFileErrorCheckErrors(error_info);
+}
+
+IN_PROC_BROWSER_TEST_F(DownloadTest,
+ DownloadErrorFileInvalidHandleWriteNavigate) {
+ FileErrorInjectInfo error_info = {
+ { "a_zip_file.zip",
+ DOWNLOAD_NAVIGATE,
+ DOWNLOAD_INTERRUPT_REASON_FILE_FAILED,
+ 1
+ },
+ FILE_OPERATION_WRITE,
+ 0,
+ net::ERR_INVALID_HANDLE
+ };
+
+ DownloadInsertFileErrorCheckErrors(error_info);
+}
+
+IN_PROC_BROWSER_TEST_F(DownloadTest,
+ DownloadErrorFileInvalidHandleWriteDirect) {
+ FileErrorInjectInfo error_info = {
+ { "a_zip_file.zip",
+ DOWNLOAD_DIRECT,
+ DOWNLOAD_INTERRUPT_REASON_FILE_FAILED,
+ 1
+ },
+ FILE_OPERATION_WRITE,
+ 0,
+ net::ERR_INVALID_HANDLE
+ };
+
+ DownloadInsertFileErrorCheckErrors(error_info);
+}
« no previous file with comments | « no previous file | content/browser/download/download_file_manager.h » ('j') | content/test/test_file_error_injector.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698