Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: content/browser/download/download_resource_handler.cc

Issue 9426029: Test file errors in downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged with trunk. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/download_item_impl.cc ('k') | content/content_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_resource_handler.cc
diff --git a/content/browser/download/download_resource_handler.cc b/content/browser/download/download_resource_handler.cc
index 4403ec1324283c0ebafee60dea1faebd433ba094..4aca33f89eccf2d8ce71be8188ce10c9ca489d5b 100644
--- a/content/browser/download/download_resource_handler.cc
+++ b/content/browser/download/download_resource_handler.cc
@@ -250,6 +250,10 @@ bool DownloadResourceHandler::OnResponseCompleted(
int request_id,
const net::URLRequestStatus& status,
const std::string& security_info) {
+ VLOG(20) << __FUNCTION__ << "()" << DebugString()
+ << " request_id = " << request_id
+ << " status.status() = " << status.status()
+ << " status.error() = " << status.error();
if (download_id_.IsValid()) {
OnResponseCompletedInternal(request_id, status, security_info);
} else {
@@ -268,7 +272,8 @@ void DownloadResourceHandler::OnResponseCompletedInternal(
int request_id,
const net::URLRequestStatus& status,
const std::string& security_info) {
- VLOG(20) << __FUNCTION__ << "()" << DebugString()
+ // NOTE: |request_| may be a dangling pointer at this point.
+ VLOG(20) << __FUNCTION__ << "()"
<< " request_id = " << request_id
<< " status.status() = " << status.status()
<< " status.error() = " << status.error();
« no previous file with comments | « content/browser/download/download_item_impl.cc ('k') | content/content_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698