Refactor BufferedSpdyFramer so that SpdySession is not a visitor of

Refactor BufferedSpdyFramer so that SpdySession is not a visitor of
both BufferedSpdyFramer and SpdyFramer.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122773

[Ryan Hamilton, 2012-02-18 00:22:56]

Hi Guys,

I believe this CL does the needful to BufferedSpdyFramer.  Please take a look...

Cheers,

Ryan

[willchan no longer on Chromium, 2012-02-18 17:41:53]

lgtm

[ramant (doing other things), 2012-02-19 23:39:56]

Could you please make changes to flip server code and fix lint errors. thanks

[ramant (doing other things), 2012-02-19 23:48:44]

lgtm

https://chromiumcodereview.appspot.com/9425023/diff/8/net/spdy/buffered_spdy_...
File net/spdy/buffered_spdy_framer.h (right):

https://chromiumcodereview.appspot.com/9425023/diff/8/net/spdy/buffered_spdy_...
net/spdy/buffered_spdy_framer.h:84: virtual void OnError(SpdyFramer*);
nit: name for argument.

[Ryan Hamilton, 2012-02-20 17:57:09]

Thanks for the LGTM.  I've fixed up the flip server too.

https://chromiumcodereview.appspot.com/9425023/diff/8/net/spdy/buffered_spdy_...
File net/spdy/buffered_spdy_framer.h (right):

https://chromiumcodereview.appspot.com/9425023/diff/8/net/spdy/buffered_spdy_...
net/spdy/buffered_spdy_framer.h:84: virtual void OnError(SpdyFramer*);
On 2012/02/19 23:48:45, ramant wrote:
> nit: name for argument.

I commented out the argument name, as per the style guide:

If some parameters are unused, comment out the variable name in the function
definition:

[commit-bot: I haz the power, 2012-02-20 17:57:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/9425023/6012

[commit-bot: I haz the power, 2012-02-20 18:17:29]

Try job failure for 9425023-6012 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2012-02-20 19:04:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/9425023/7012

[commit-bot: I haz the power, 2012-02-20 20:21:34]

Change committed as 122773

[James Hawkins, 2012-02-20 21:45:43]

http://codereview.chromium.org/9425023/diff/7012/net/spdy/buffered_spdy_frame...
File net/spdy/buffered_spdy_framer.cc (right):

http://codereview.chromium.org/9425023/diff/7012/net/spdy/buffered_spdy_frame...
net/spdy/buffered_spdy_framer.cc:33: frames_received_++;
|frames_received_| is uninitialized.