Change MockRead and MockWrite (et. al.) to take an IoMode enum, instead

net/dns/dns_transaction_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/dns_transaction.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/rand_util.h"
@@ skipping 224 matching lines @@
                    const char* data,
                    size_t data_length) {
     CHECK(socket_factory_.get());
     DnsQuery* query = new DnsQuery(id, DomainFromDot(dotted_name), qtype);
     queries_.push_back(query);
 
     // The response is only used to hold the IOBuffer.
     DnsResponse* response = new DnsResponse(data, data_length, 0);
     responses_.push_back(response);
 
-    writes_.push_back(MockWrite(true,
+    writes_.push_back(MockWrite(ASYNC,
                                 query->io_buffer()->data(),
                                 query->io_buffer()->size()));
-    reads_.push_back(MockRead(true,
+    reads_.push_back(MockRead(ASYNC,
                               response->io_buffer()->data(),
                               data_length));
 
     transaction_ids_.push_back(id);
   }
 
   // Add expected query of |dotted_name| and |qtype| and no response.
   void AddTimeout(const char* dotted_name, uint16 qtype) {
     CHECK(socket_factory_.get());
     uint16 id = base::RandInt(0, kuint16max);
     DnsQuery* query = new DnsQuery(id, DomainFromDot(dotted_name), qtype);
     queries_.push_back(query);
 
-    writes_.push_back(MockWrite(true,
+    writes_.push_back(MockWrite(ASYNC,
                                 query->io_buffer()->data(),
                                 query->io_buffer()->size()));
     // Empty MockRead indicates no data.
     reads_.push_back(MockRead());
     transaction_ids_.push_back(id);
   }
 
   // Add expected query of |dotted_name| and |qtype| and response with no answer
   // and rcode set to |rcode|.
   void AddRcode(const char* dotted_name, uint16 qtype, int rcode) {
     CHECK(socket_factory_.get());
     CHECK_NE(dns_protocol::kRcodeNOERROR, rcode);
     uint16 id = base::RandInt(0, kuint16max);
     DnsQuery* query = new DnsQuery(id, DomainFromDot(dotted_name), qtype);
     queries_.push_back(query);
 
     DnsResponse* response = new DnsResponse(query->io_buffer()->data(),
                                             query->io_buffer()->size(),
                                             0);
     dns_protocol::Header* header =
         reinterpret_cast<dns_protocol::Header*>(response->io_buffer()->data());
     header->flags |= htons(dns_protocol::kFlagResponse | rcode);
     responses_.push_back(response);
 
-    writes_.push_back(MockWrite(true,
+    writes_.push_back(MockWrite(ASYNC,
                                 query->io_buffer()->data(),
                                 query->io_buffer()->size()));
-    reads_.push_back(MockRead(true,
+    reads_.push_back(MockRead(ASYNC,
                               response->io_buffer()->data(),
                               query->io_buffer()->size()));
     transaction_ids_.push_back(id);
   }
 
   // Call after all Add* calls to prepare data for |socket_factory_|.
   // This separation is necessary because the |reads_| and |writes_| vectors
   // could reallocate their data during those calls.
   void PrepareSockets() {
     CHECK_EQ(writes_.size(), reads_.size());
@@ skipping 374 matching lines @@
   TransactionHelper helper2("x",
                             dns_protocol::kTypeA,
                             ERR_NAME_NOT_RESOLVED);
   EXPECT_TRUE(helper2.Run(transaction_factory_.get()));
 }
 
 }  // namespace
 
 }  // namespace net