Fix most of the downloads api in incognito profiles

chrome/common/extensions/api/experimental_downloads.json

Index: chrome/common/extensions/api/experimental_downloads.json
diff --git a/chrome/common/extensions/api/experimental_downloads.json b/chrome/common/extensions/api/experimental_downloads.json
index 3aeecb230745fa4921230a09151ddad9af99ed6d..6bb443602b60e06615856d09a48cf290dd868b17 100644
--- a/chrome/common/extensions/api/experimental_downloads.json
+++ b/chrome/common/extensions/api/experimental_downloads.json
@@ -142,6 +142,11 @@
             "type": "string",
             "description": "absolute local path"
           },
+          "incognito": {
+            "type": "boolean",
+            "description": "True if this download is off-the-record, false otherwise.",

[Matt Perry, 2012/05/14 22:57:11]

off-the-record is a term internal to chrome. Use "incognito"

[benjhayden, 2012/05/15 17:16:25]

Done.

+            "optional": true
+          },
           "danger": {
             "$ref": "DownloadDangerType",
             "description": "Indication of whether this download is thought to be safe or known to be suspicious.",
@@ -269,6 +274,12 @@
             "optional": true,
             "description": "absolute local path"
           },
+          "incognito": {

[Matt Perry, 2012/05/14 22:57:11]

I don't think we should expose this to the API. It should be more transparent.
This is how I think it should work:
- If the extension is not enabled in incognito, it can't see incognito
downloads.
- If it is enabled, and uses "spanning" incognito mode, it can see all
downloads.
- If it is enabled, and uses "split" incognito mode, then there will be 2
extension processes:
--- the regular one can only see regular downloads.
--- the incognito one can only see incognito downloads.

[Matt Perry, 2012/05/14 22:58:55]

BTW, ExtensionFunction::include_incognito_ is intended to facilitate this. If
the value is true, then you should include info from both profiles. If the value
is false, then you should only include info from ExtensionFunction::profile_
(which will be either regular or incognito, depending on which process is
calling the function).

[benjhayden, 2012/05/15 17:16:25]

Done.

[benjhayden, 2012/05/15 17:16:25]

Done.

+            "type": "string",
+            "optional": true,
+            "enum": ["none", "only"],
+            "description": "Whether to include only off-the-record downloads in the results, or no off-the-record downloads. The default (undefined) is to include both."
+          },
           "danger": {
             "$ref": "DownloadDangerType",
             "description": "Indication of whether this download is thought to be safe or known to be suspicious.",