Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: ipc/ipc_message.h

Issue 9425006: Make IPC_MESSAGE_EXPORT more robust. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/utility_messages.h ('k') | ipc/ipc_message_macros.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_message.h
diff --git a/ipc/ipc_message.h b/ipc/ipc_message.h
index b978cf23680924924141d105020541d66511bd4a..5c266819363eb95ea1c950c4a51b5850399b2a61 100644
--- a/ipc/ipc_message.h
+++ b/ipc/ipc_message.h
@@ -12,7 +12,10 @@
#include "base/pickle.h"
#include "ipc/ipc_export.h"
-#ifndef NDEBUG
+// Ipc logging adds a dependency from the 'chrome' target on all ipc message
+// classes. In a component build, this would require exporting all message
+// classes, so don't support ipc logging in the components build.
+#if !defined(NDEBUG) && !defined(COMPONENT_BUILD)
#define IPC_MESSAGE_LOG_ENABLED
#endif
« no previous file with comments | « content/common/utility_messages.h ('k') | ipc/ipc_message_macros.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698