Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: chrome/common/extensions/extension_permission_set_unittest.cc

Issue 9424036: Move `browsingData` extension API out of experimental. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebuilt docs. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/common/extensions/extension_permission_set.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_permission_set.h" 5 #include "chrome/common/extensions/extension_permission_set.h"
6 6
7 #include "base/json/json_value_serializer.h" 7 #include "base/json/json_value_serializer.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 746 matching lines...) Expand 10 before | Expand all | Expand 10 after
757 } 757 }
758 758
759 TEST(ExtensionPermissionsTest, PermissionMessages) { 759 TEST(ExtensionPermissionsTest, PermissionMessages) {
760 // Ensure that all permissions that needs to show install UI actually have 760 // Ensure that all permissions that needs to show install UI actually have
761 // strings associated with them. 761 // strings associated with them.
762 ExtensionAPIPermissionSet skip; 762 ExtensionAPIPermissionSet skip;
763 763
764 // These are considered "nuisance" or "trivial" permissions that don't need 764 // These are considered "nuisance" or "trivial" permissions that don't need
765 // a prompt. 765 // a prompt.
766 skip.insert(ExtensionAPIPermission::kAppNotifications); 766 skip.insert(ExtensionAPIPermission::kAppNotifications);
767 skip.insert(ExtensionAPIPermission::kBrowsingData);
767 skip.insert(ExtensionAPIPermission::kContextMenus); 768 skip.insert(ExtensionAPIPermission::kContextMenus);
768 skip.insert(ExtensionAPIPermission::kIdle); 769 skip.insert(ExtensionAPIPermission::kIdle);
769 skip.insert(ExtensionAPIPermission::kNotification); 770 skip.insert(ExtensionAPIPermission::kNotification);
770 skip.insert(ExtensionAPIPermission::kUnlimitedStorage); 771 skip.insert(ExtensionAPIPermission::kUnlimitedStorage);
771 skip.insert(ExtensionAPIPermission::kStorage); 772 skip.insert(ExtensionAPIPermission::kStorage);
772 skip.insert(ExtensionAPIPermission::kTts); 773 skip.insert(ExtensionAPIPermission::kTts);
773 774
774 // TODO(erikkay) add a string for this permission. 775 // TODO(erikkay) add a string for this permission.
775 skip.insert(ExtensionAPIPermission::kBackground); 776 skip.insert(ExtensionAPIPermission::kBackground);
776 777
(...skipping 518 matching lines...) Expand 10 before | Expand all | Expand 10 after
1295 AddPattern(&non_empty_extent, "http://www.google.com/*"); 1296 AddPattern(&non_empty_extent, "http://www.google.com/*");
1296 1297
1297 perm_set = new ExtensionPermissionSet( 1298 perm_set = new ExtensionPermissionSet(
1298 empty_apis, non_empty_extent, empty_extent); 1299 empty_apis, non_empty_extent, empty_extent);
1299 EXPECT_FALSE(perm_set->IsEmpty()); 1300 EXPECT_FALSE(perm_set->IsEmpty());
1300 1301
1301 perm_set = new ExtensionPermissionSet( 1302 perm_set = new ExtensionPermissionSet(
1302 empty_apis, empty_extent, non_empty_extent); 1303 empty_apis, empty_extent, non_empty_extent);
1303 EXPECT_FALSE(perm_set->IsEmpty()); 1304 EXPECT_FALSE(perm_set->IsEmpty());
1304 } 1305 }
OLDNEW
« no previous file with comments | « chrome/common/extensions/extension_permission_set.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698