Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: chrome/renderer/resources/extensions/page_actions_custom_bindings.js

Issue 9423049: Make registering custom hooks with schema_generated_bindings.js safer and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom bindings for the pageActions API. 5 // Custom bindings for the pageActions API.
6 6
7 (function() { 7 (function() {
8 8
9 native function GetChromeHidden(); 9 native function GetChromeHidden();
10 native function GetCurrentPageActions(); 10 native function GetCurrentPageActions();
11 11
12 GetChromeHidden().registerCustomHook( 12 GetChromeHidden().registerCustomHook('pageActions',
13 'pageActions', function(bindingsAPI, extensionId) { 13 function(bindingsAPI, extensionId) {
14 var pageActions = GetCurrentPageActions(extensionId); 14 var pageActions = GetCurrentPageActions(extensionId);
15 var oldStyleEventName = "pageActions"; 15 var oldStyleEventName = 'pageActions';
16 for (var i = 0; i < pageActions.length; ++i) { 16 for (var i = 0; i < pageActions.length; ++i) {
17 // Setup events for each extension_id/page_action_id string we find. 17 // Setup events for each extension_id/page_action_id string we find.
18 chrome.pageActions[pageActions[i]] = new chrome.Event(oldStyleEventName); 18 chrome.pageActions[pageActions[i]] = new chrome.Event(oldStyleEventName);
19 } 19 }
20 }); 20 });
21 21
22 })(); 22 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698