Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: chrome/renderer/resources/extensions/devtools_custom_bindings.js

Issue 9423049: Make registering custom hooks with schema_generated_bindings.js safer and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom bindings for the devtools API. 5 // Custom bindings for the devtools API.
6 6
7 (function() { 7 (function() {
8 8
9 native function GetChromeHidden(); 9 native function GetChromeHidden();
10 10
11 GetChromeHidden().registerCustomHook('devtools', function(bindingsAPI) { 11 GetChromeHidden().registerCustomHook('devtools', function(bindingsAPI) {
12 var apiFunctions = bindingsAPI.apiFunctions; 12 var apiFunctions = bindingsAPI.apiFunctions;
13 13
14 apiFunctions.setHandleRequest('devtools.getTabEvents', function(tabId) { 14 apiFunctions.setHandleRequest('getTabEvents', function(tabId) {
15 var tabIdProxy = {}; 15 var tabIdProxy = {};
16 var functions = ['onPageEvent', 'onTabClose']; 16 var functions = ['onPageEvent', 'onTabClose'];
17 functions.forEach(function(name) { 17 functions.forEach(function(name) {
18 // Event disambiguation is handled by name munging. See 18 // Event disambiguation is handled by name munging. See
19 // chrome/browser/extensions/extension_devtools_events.h for the C++ 19 // chrome/browser/extensions/extension_devtools_events.h for the C++
20 // equivalent of this logic. 20 // equivalent of this logic.
21 tabIdProxy[name] = new chrome.Event('devtools.' + tabId + '.' + name); 21 tabIdProxy[name] = new chrome.Event('devtools.' + tabId + '.' + name);
22 }); 22 });
23 return tabIdProxy; 23 return tabIdProxy;
24 }); 24 });
25 }); 25 });
26 26
27 })(); 27 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698