Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: chrome/renderer/resources/extensions/browser_action_custom_bindings.js

Issue 9423049: Make registering custom hooks with schema_generated_bindings.js safer and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/chrome_private_custom_bindings.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom bindings for the browserAction API. 5 // Custom bindings for the browserAction API.
6 6
7 (function() { 7 (function() {
8 8
9 native function GetChromeHidden(); 9 native function GetChromeHidden();
10 10
11 GetChromeHidden().registerCustomHook('browserAction', function(bindingsAPI) { 11 GetChromeHidden().registerCustomHook('browserAction', function(bindingsAPI) {
12 var apiFunctions = bindingsAPI.apiFunctions; 12 var apiFunctions = bindingsAPI.apiFunctions;
13 var setIcon = bindingsAPI.setIcon; 13 var setIcon = bindingsAPI.setIcon;
14 14
15 apiFunctions.setHandleRequest('browserAction.setIcon', function(details) { 15 apiFunctions.setHandleRequest('setIcon', function(details) {
16 setIcon(details, this.name, this.definition.parameters, 'browser action'); 16 setIcon(details, this.name, this.definition.parameters, 'browser action');
17 }); 17 });
18 }); 18 });
19 19
20 })(); 20 })();
OLDNEW
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/chrome_private_custom_bindings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698