Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 9423035: Fix json_schema_compiler utils (Closed)

Created:
8 years, 10 months ago by calamity
Modified:
8 years, 10 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

json_schema_compiler: make util::AddItemToList take a const reference to match the compiler. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/json_schema_compiler/util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
calamity
8 years, 10 months ago (2012-02-19 23:37:03 UTC) #1
not at google - send to devlin
LGTM.
8 years, 10 months ago (2012-02-19 23:39:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/9423035/1
8 years, 10 months ago (2012-02-19 23:41:40 UTC) #3
commit-bot: I haz the power
8 years, 10 months ago (2012-02-20 00:49:02 UTC) #4
Change committed as 122725

Powered by Google App Engine
This is Rietveld 408576698