Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 9423018: shorten long bindings lines for Windows builds (Closed)

Created:
8 years, 10 months ago by Scott Byer
Modified:
8 years, 9 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Visibility:
Public.

Description

shorten long bindings lines for Windows builds BUG=none TEST=build using the command line on Windows, piping through sed, see less extraneous output Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124754

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/sanitize-win-build-log.sed View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Scott Byer
8 years, 10 months ago (2012-02-17 22:32:50 UTC) #1
Scott Byer
Since Evan has moved off of Chromium, and you seem to be the other person ...
8 years, 10 months ago (2012-02-27 17:48:51 UTC) #2
dcheng
Sorry for missing this review. Since I've never built from the command-line on Windows, do ...
8 years, 9 months ago (2012-03-02 17:55:29 UTC) #3
Scott Byer
On 2012/03/02 17:55:29, dcheng wrote: > Sorry for missing this review. Since I've never built ...
8 years, 9 months ago (2012-03-02 19:27:49 UTC) #4
dcheng
lgtm
8 years, 9 months ago (2012-03-02 19:32:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottbyer@chromium.org/9423018/1
8 years, 9 months ago (2012-03-02 20:36:12 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 22:48:57 UTC) #7
Change committed as 124754

Powered by Google App Engine
This is Rietveld 408576698