Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 9423016: Windows Breakpad: Stop doing Breakpad initialisation on a thread (Closed)

Created:
8 years, 10 months ago by Mark Seaborn
Modified:
8 years, 10 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

Windows Breakpad: Stop doing Breakpad initialisation on a thread The Breakpad setup was being done on a thread because reading metadata chrome.dll was slow, but the code has been changed to read the metadata from chrome.exe which should be faster. I need to remove the use of threading so that I can change the Breakpad enablement checks to happen only in the browser process and be inherited reliably by subprocesses. Also, this will potentially make any crashes on startup more reliably reported by Breakpad. BUG=111265 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -30 lines) Patch
M chrome/app/breakpad_win.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/breakpad_win.cc View 8 chunks +7 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mark Seaborn
8 years, 10 months ago (2012-02-18 00:06:54 UTC) #1
Mark Seaborn
8 years, 10 months ago (2012-02-21 08:21:32 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
8 years, 10 months ago (2012-02-22 21:01:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/9423016/1
8 years, 10 months ago (2012-02-22 21:15:00 UTC) #4
commit-bot: I haz the power
Try job failure for 9423016-1 (retry) on linux_rel for step "browser_tests" (clobber build). It's a ...
8 years, 10 months ago (2012-02-22 22:10:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/9423016/1
8 years, 10 months ago (2012-02-22 22:21:53 UTC) #6
commit-bot: I haz the power
8 years, 10 months ago (2012-02-23 00:27:23 UTC) #7
Change committed as 123149

Powered by Google App Engine
This is Rietveld 408576698