isolates refactor: this change introduces 'dart:isolate' as a library. This is a

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
 #include "vm/bootstrap.h"
@@ skipping 639 matching lines @@
   Error& error = Error::Handle();
   error = Bootstrap::Compile(core_lib, script);
   if (!error.IsNull()) {
     return error.raw();
   }
   error = Bootstrap::Compile(core_impl_lib, impl_script);
   if (!error.IsNull()) {
     return error.raw();
   }
 
+  // Load other libraries, such as dart:isolate.
+  error = Bootstrap::InitAdditionalLibraries();
+  if (!error.IsNull()) {
+    return error.raw();
+  }
+
+  Library& isolate_lib = Library::Handle(Library::IsolateLibrary());
+  ASSERT(!isolate_lib.IsNull());

[siva, 2012/02/22 00:58:20]

I noticed that these changes are similar to the ones that Todd is doing for
'dart::mirrors'. There are some review comments in that CL. I am assuming you
will reconcile with Todd's changes once he submits them.

[Siggi Cherem (dart-lang), 2012/02/22 19:18:50]

I'm happy to do so, but since Todd is on vacation, I might submit this before.
In that case, would you like me to do some of the changes here?

I saw your comment on changing InitAdditionalLibraries to return RawObject, but
I'm not sure how far does you want that change to go. Did you mean to change
also Bootstrap::Compile to return RawObject*, and here Object::Init too? (so we
do the error handler allocation only in dart.cc (InitializeIsolate)?

[siva, 2012/02/22 23:18:14]

I think we should probably have Todd reconcile when he submits his changes.
My comment was a generic one but I was referring to the code in
InitAdditionalLibraries which had to create an Error handle and re - assign etc.
Not sure if there is code like that in other spots too. 

+
   Bootstrap::SetupNativeResolver();
 
   // Remove the Object superclass cycle by setting the super type to null (not
   // to the type of null).
   cls = object_store->object_class();
   cls.set_super_type(Type::Handle());
 
   ClassFinalizer::VerifyBootstrapClasses();
   return Error::null();
 }
@@ skipping 4051 matching lines @@
 RawLibrary* Library::CoreLibrary() {
   return Isolate::Current()->object_store()->core_library();
 }
 
 
 RawLibrary* Library::CoreImplLibrary() {
   return Isolate::Current()->object_store()->core_impl_library();
 }
 
 
+RawLibrary* Library::IsolateLibrary() {
+  return Isolate::Current()->object_store()->isolate_library();
+}
+
+
 RawLibrary* Library::NativeWrappersLibrary() {
   return Isolate::Current()->object_store()->native_wrappers_library();
 }
 
 
 const char* Library::ToCString() const {
   const char* kFormat = "Library:'%s'";
   const String& name = String::Handle(url());
   intptr_t len = OS::SNPrint(NULL, 0, kFormat, name.ToCString()) + 1;
   char* chars = reinterpret_cast<char*>(
@@ skipping 3453 matching lines @@
   const String& str = String::Handle(pattern());
   const char* format = "JSRegExp: pattern=%s flags=%s";
   intptr_t len = OS::SNPrint(NULL, 0, format, str.ToCString(), Flags());
   char* chars = reinterpret_cast<char*>(
       Isolate::Current()->current_zone()->Allocate(len + 1));
   OS::SNPrint(chars, (len + 1), format, str.ToCString(), Flags());
   return chars;
 }
 
 }  // namespace dart