Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 9421014: Remove temporary workaround for http://codereview.chromium.org/9419020/ (Closed)

Created:
8 years, 10 months ago by Xianzhu
Modified:
8 years, 10 months ago
Reviewers:
John Grabowski, Yaron
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove temporary workaround for http://codereview.chromium.org/9419020/ http://codereview.chromium.org/9419020 was blocked by crbug.com/109763 without the workaround. Now remove the workaround. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M build/all_android.gyp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Xianzhu
8 years, 10 months ago (2012-02-18 00:12:19 UTC) #1
Yaron
On 2012/02/18 00:12:19, Xianzhu wrote: lgtm but you need approval from a committer (e.g. jrg)
8 years, 10 months ago (2012-02-18 00:14:54 UTC) #2
Xianzhu
8 years, 10 months ago (2012-02-18 00:22:56 UTC) #3
John Grabowski
I like, but can you give me a hint on how this will impact load? ...
8 years, 10 months ago (2012-02-18 00:38:39 UTC) #4
Xianzhu
On 2012/02/18 00:38:39, John Grabowski wrote: > I like, but can you give me a ...
8 years, 10 months ago (2012-02-18 18:59:51 UTC) #5
John Grabowski
Thanks for the details. LGTM
8 years, 10 months ago (2012-02-21 01:09:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/9421014/1
8 years, 10 months ago (2012-02-21 19:11:29 UTC) #7
commit-bot: I haz the power
8 years, 10 months ago (2012-02-21 20:53:09 UTC) #8
Change committed as 122870

Powered by Google App Engine
This is Rietveld 408576698