Heartbeat implementation of dart:mirrors.

runtime/vm/isolate.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/isolate.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/bigint_store.h"
 #include "vm/code_index_table.h"
@@ skipping 49 matching lines @@
 }
 
 const char* IsolateMessageHandler::name() const {
   return isolate_->name();
 }
 
 
 void IsolateMessageHandler::MessageNotify(Message::Priority priority) {
   if (priority >= Message::kOOBPriority) {
     // Handle out of band messages even if the isolate is busy.
-    // isolate_->ScheduleInterrupts(Isolate::kMessageInterrupt);
-    UNIMPLEMENTED();
+    isolate_->ScheduleInterrupts(Isolate::kMessageInterrupt);
   }
   Dart_MessageNotifyCallback callback = isolate_->message_notify_callback();
   if (callback) {
     // Allow the embedder to handle message notification.
     (*callback)(Api::CastIsolate(isolate_));
   }
 }
 
 
 #if defined(DEBUG)
@@ skipping 295 matching lines @@
 static RawInstance* DeserializeMessage(void* data) {
   // Create a snapshot object using the buffer.
   const Snapshot* snapshot = Snapshot::SetupFromBuffer(data);
   ASSERT(snapshot->IsMessageSnapshot());
 
   // Read object back from the snapshot.
   SnapshotReader reader(snapshot, Isolate::Current());
   Instance& instance = Instance::Handle();
   instance ^= reader.ReadObject();
   return instance.raw();
 }

[siva, 2012/02/18 01:25:55]

Ditto comment about code being duplicated here.

 
 
 
 RawError* Isolate::StandardRunLoop() {
   ASSERT(message_notify_callback() == NULL);
   ASSERT(message_handler() != NULL);
 
   while (message_handler()->HasLivePorts()) {
     ASSERT(this == Isolate::Current());
     Zone zone(this);
     HandleScope handle_scope(this);
 
     Message* message = message_handler()->queue()->Dequeue(0);
     if (message != NULL) {
-      if (message->priority() >= Message::kOOBPriority) {
-        // TODO(turnidge): Out of band messages will not go through the
-        // regular message handler.  Instead they will be dispatched to
-        // special vm code.  Implement.
-        UNIMPLEMENTED();
-      }
       const Instance& msg =
           Instance::Handle(DeserializeMessage(message->data()));
-      const Object& result = Object::Handle(
-          DartLibraryCalls::HandleMessage(
-              message->dest_port(), message->reply_port(), msg));
-      delete message;
-      if (result.IsError()) {
-        Error& error = Error::Handle();
-        error ^= result.raw();
-        return error.raw();
+      if (message->priority() >= Message::kOOBPriority) {
+        // For now the only OOB messages are Mirrors messages.
+        const Object& result = Object::Handle(
+            DartLibraryCalls::HandleMirrorsMessage(
+                message->dest_port(), message->reply_port(), msg));
+        delete message;
+        if (result.IsError()) {
+          // TODO(turnidge): Propagating the error is probably wrong here.
+          Error& error = Error::Handle();
+          error ^= result.raw();
+          return error.raw();
+        }
+        ASSERT(result.IsNull());
+      } else {
+        const Object& result = Object::Handle(
+            DartLibraryCalls::HandleMessage(
+                message->dest_port(), message->reply_port(), msg));
+        delete message;
+        if (result.IsError()) {
+          Error& error = Error::Handle();
+          error ^= result.raw();
+          return error.raw();
+        }
+        ASSERT(result.IsNull());

[siva, 2012/02/18 01:25:55]

Ditto comment about code being duplicated here.

       }
-      ASSERT(result.IsNull());
     }
   }
 
   // Indicates success.
   return Error::null();
 }
 
 
 void Isolate::VisitObjectPointers(ObjectPointerVisitor* visitor,
                                   bool validate_frames) {
@@ skipping 34 matching lines @@
 }
 
 
 void Isolate::VisitWeakPersistentHandles(HandleVisitor* visitor) {
   if (api_state() != NULL) {
     api_state()->VisitWeakHandles(visitor);
   }
 }
 
 }  // namespace dart