Issue 9420027: dbus: ProperySet destructor must be virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9420027: dbus: ProperySet destructor must be virtual (Closed)

Created:
8 years, 10 months ago by keybuk

Modified:
8 years, 10 months ago

Reviewers:
satorux1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

dbus: ProperySet destructor must be virtual clang requires us to have a destructor for this "complex" class, but that destructor will need to be virtual later. BUG=none TEST=git try -b linux_chromeos_clang Change-Id: Ia0efd34f205ab090cd7f2092d47fc0288b1f4e0c Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122417

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	dbus/property.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/9420027/1

8 years, 10 months ago (2012-02-16 23:22:36 UTC) #3

Change committed as 122417

Expand Messages | Collapse Messages