Modify the MockConnect constructor to take an enum of ASYNC or SYNC, instead

Modify the MockConnect constructor to take an enum of ASYNC or SYNCHRONOUS,
instead of a boolean async.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122581

[Ryan Hamilton, 2012-02-17 03:41:37]

Jim, can you take a look at this and let me know what you think?  I will follow
up this change with a number of others fixing the various "bool async" arguments
in other classes.

[jar (doing other things), 2012-02-17 17:19:16]

LGTM

Nice cleanup and readability improvement IMO ;-).

Thanks!

https://chromiumcodereview.appspot.com/9419032/diff/2079/net/http/http_proxy_...
File net/http/http_proxy_client_socket_pool_unittest.cc (right):

https://chromiumcodereview.appspot.com/9419032/diff/2079/net/http/http_proxy_...
net/http/http_proxy_client_socket_pool_unittest.cc:166: ssl_data_.reset(new
SSLSocketDataProvider(false, OK));
There is a chance that this strategy should be pushed further... into
SSLSocketDataProvider.... but already this is a very good change.

[Ryan Hamilton, 2012-02-17 17:33:56]

akalin: can you look at the jingle changes?  (this should be a fast review)

http://codereview.chromium.org/9419032/diff/2079/net/http/http_proxy_client_s...
File net/http/http_proxy_client_socket_pool_unittest.cc (right):

http://codereview.chromium.org/9419032/diff/2079/net/http/http_proxy_client_s...
net/http/http_proxy_client_socket_pool_unittest.cc:166: ssl_data_.reset(new
SSLSocketDataProvider(false, OK));
On 2012/02/17 17:19:16, jar wrote:
> There is a chance that this strategy should be pushed further... into
> SSLSocketDataProvider.... but already this is a very good change.

Yes, totally agree.  I want to push this change into MockRead/MockWrite, and all
the *SocketData providers.  (But once CL at a time so that this CL doesn't touch
every line in every test :>)

[commit-bot: I haz the power, 2012-02-17 19:31:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/9419032/2079

[akalin, 2012-02-17 19:46:48]

LGTM

http://codereview.chromium.org/9419032/diff/2079/jingle/notifier/base/fake_ss...
File jingle/notifier/base/fake_ssl_client_socket_unittest.cc (right):

http://codereview.chromium.org/9419032/diff/2079/jingle/notifier/base/fake_ss...
jingle/notifier/base/fake_ssl_client_socket_unittest.cc:134: net::MockConnect
mock_connect(async ? net::ASYNC : net::SYNCHRONOUS,
ideally you'd propagate the enum up, but that's not critical

[Ryan Hamilton, 2012-02-17 19:58:09]

Thanks for the LGTM!

http://codereview.chromium.org/9419032/diff/2079/jingle/notifier/base/fake_ss...
File jingle/notifier/base/fake_ssl_client_socket_unittest.cc (right):

http://codereview.chromium.org/9419032/diff/2079/jingle/notifier/base/fake_ss...
jingle/notifier/base/fake_ssl_client_socket_unittest.cc:134: net::MockConnect
mock_connect(async ? net::ASYNC : net::SYNCHRONOUS,
On 2012/02/17 19:46:49, akalin wrote:
> ideally you'd propagate the enum up, but that's not critical

Yup, I intend to do that in a subsequent CL, coming soon...

[commit-bot: I haz the power, 2012-02-17 21:02:37]

Change committed as 122581