Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 9419029: Fix the CountFilesCreatedAfter test. (Closed)

Created:
8 years, 10 months ago by Greg Billock
Modified:
8 years, 10 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Fix the CountFilesCreatedAfter test. R=evan@chromium.org BUG=46246 TEST=FileUtilTest.CountFilesCreatedAfter Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122443

Patch Set 1 #

Patch Set 2 : Better version of test? #

Patch Set 3 : Switch to new test impl. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -27 lines) Patch
M base/file_util_unittest.cc View 1 2 1 chunk +16 lines, -27 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Greg Billock
8 years, 10 months ago (2012-02-17 00:24:14 UTC) #1
Evan Martin
LGTM
8 years, 10 months ago (2012-02-17 00:39:27 UTC) #2
Greg Billock
On 2012/02/17 00:39:27, Evan Martin wrote: > LGTM Shall I kill the original version and ...
8 years, 10 months ago (2012-02-17 01:01:10 UTC) #3
Evan Martin
LGTM
8 years, 10 months ago (2012-02-17 01:02:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/9419029/2005
8 years, 10 months ago (2012-02-17 01:30:39 UTC) #5
commit-bot: I haz the power
Presubmit check for 9419029-2005 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-02-17 01:30:41 UTC) #6
Greg Billock
Need OWNERS lgtm On 2012/02/17 01:30:41, I haz the power (commit-bot) wrote: > Presubmit check ...
8 years, 10 months ago (2012-02-17 01:33:05 UTC) #7
willchan no longer on Chromium
Wait, didn't Evan already approve this? On Thu, Feb 16, 2012 at 5:33 PM, <gbillock@chromium.org> ...
8 years, 10 months ago (2012-02-17 01:49:32 UTC) #8
willchan no longer on Chromium
LGTM On Thu, Feb 16, 2012 at 5:49 PM, William Chan (陈智昌) <willchan@chromium.org>wrote: > Wait, ...
8 years, 10 months ago (2012-02-17 01:55:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/9419029/2005
8 years, 10 months ago (2012-02-17 01:57:13 UTC) #10
commit-bot: I haz the power
8 years, 10 months ago (2012-02-17 03:32:10 UTC) #11
Change committed as 122443

Powered by Google App Engine
This is Rietveld 408576698