Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 9419010: Fix Mac custom cursor color. (Closed)

Created:
8 years, 10 months ago by Avi (use Gerrit)
Modified:
8 years, 10 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Fix Mac custom cursor color. BUG=114598 TEST=as in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122386

Patch Set 1 #

Patch Set 2 : if no data, clear #

Patch Set 3 : test shell change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -19 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/native_widget_types.h View 3 chunks +3 lines, -1 line 0 comments Download
M webkit/glue/webcursor.h View 2 chunks +1 line, -4 lines 0 comments Download
M webkit/glue/webcursor_mac.mm View 1 8 chunks +41 lines, -12 lines 0 comments Download
M webkit/tools/test_shell/mac/test_webview_delegate.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
Avi (use Gerrit)
8 years, 10 months ago (2012-02-16 16:23:15 UTC) #1
_cary
lgtm
8 years, 10 months ago (2012-02-16 16:38:18 UTC) #2
Avi (use Gerrit)
On 2012/02/16 16:38:18, _cary wrote: > lgtm forgot to explicitly clear the bitmap if there ...
8 years, 10 months ago (2012-02-16 16:42:32 UTC) #3
_cary
I was wondering about that. I thought that maybe allocPixels zeroed its data, but that ...
8 years, 10 months ago (2012-02-16 16:48:44 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 10 months ago (2012-02-16 18:55:41 UTC) #5
Avi (use Gerrit)
Robert, can you take a look for approval?
8 years, 10 months ago (2012-02-16 19:07:44 UTC) #6
Robert Sesek
lgtm
8 years, 10 months ago (2012-02-16 19:36:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9419010/3001
8 years, 10 months ago (2012-02-16 19:41:32 UTC) #8
commit-bot: I haz the power
Presubmit check for 9419010-3001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-02-16 19:41:38 UTC) #9
Avi (use Gerrit)
OWNERS ben: ui/ darin: webkit/
8 years, 10 months ago (2012-02-16 19:43:32 UTC) #10
Avi (use Gerrit)
I need some OWNERS approvals. Sorry to be annoying but this is a happy little ...
8 years, 10 months ago (2012-02-16 20:15:52 UTC) #11
tony
webkit LGTM
8 years, 10 months ago (2012-02-16 20:26:05 UTC) #12
Ben Goodger (Google)
lgtm
8 years, 10 months ago (2012-02-16 20:32:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9419010/3001
8 years, 10 months ago (2012-02-16 20:38:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9419010/8
8 years, 10 months ago (2012-02-16 21:21:30 UTC) #15
darin (slow to review)
LGTM for webkit/
8 years, 10 months ago (2012-02-16 21:23:24 UTC) #16
commit-bot: I haz the power
8 years, 10 months ago (2012-02-16 23:22:10 UTC) #17
Change committed as 122386

Powered by Google App Engine
This is Rietveld 408576698