Made bash completion work for OSX

Made bash completion work for OSX


BUG=none
TEST=try autocompletion for OSX Chromium


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122944

[groby-ooo-7-16, 2012-02-17 02:01:44]

Please review

Unfortunately, OSX chokes on readline -f and has different sed syntax, so quite
a chunk of new code. (Also, much appreciated if you could try it on Linux. Still
works on my ubiquity instance, but just in case...)

[Evan Martin, 2012-02-17 20:23:17]

https://chromiumcodereview.appspot.com/9418030/diff/1/tools/bash-completion
File tools/bash-completion (right):

https://chromiumcodereview.appspot.com/9418030/diff/1/tools/bash-completion#n...
tools/bash-completion:12: $chrome_source)
Simpler:
chrome_source=$((cd $chrome_source && pwd))

https://chromiumcodereview.appspot.com/9418030/diff/1/tools/bash-completion#n...
tools/bash-completion:13: sed_expr='s/^[^/]*"\([^" /]*\)".*/--\1/p'
Why is this different between Darwin and not?

[groby-ooo-7-16, 2012-02-17 22:19:28]

https://chromiumcodereview.appspot.com/9418030/diff/1/tools/bash-completion
File tools/bash-completion (right):

https://chromiumcodereview.appspot.com/9418030/diff/1/tools/bash-completion#n...
tools/bash-completion:12: $chrome_source)
Surely you only meant one level of parens :)

On 2012/02/17 20:23:17, Evan Martin wrote:
> Simpler:
> chrome_source=$((cd $chrome_source && pwd))

https://chromiumcodereview.appspot.com/9418030/diff/1/tools/bash-completion#n...
tools/bash-completion:13: sed_expr='s/^[^/]*"\([^" /]*\)".*/--\1/p'
Because Darwin doesn't support \+. And if I'd read ed(1) instead of re_format(7)
right away, I would've known. Ah well - have a cross-platform, if ugly,
alternative w/ latest.

On 2012/02/17 20:23:17, Evan Martin wrote:
> Why is this different between Darwin and not?

[groby-ooo-7-16, 2012-02-22 00:08:20]

Ping?

[Evan Martin, 2012-02-22 00:12:37]

LGTM

[commit-bot: I haz the power, 2012-02-22 00:13:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/9418030/4001

[commit-bot: I haz the power, 2012-02-22 01:47:46]

Change committed as 122944