Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 9416107: Change to interface to M19, add a few more test cases to test_audio. (Closed)

Created:
8 years, 10 months ago by nfullagar
Modified:
8 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Change to interface to M19, add a few more test cases to test_audio. BUG=http://code.google.com/p/chromium/issues/detail?id=115305 TEST=test_audio.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123531

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M ppapi/api/ppb_audio_config.idl View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M ppapi/c/ppb_audio_config.h View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M ppapi/tests/test_audio.cc View 1 2 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
nfullagar
8 years, 10 months ago (2012-02-22 19:38:25 UTC) #1
brettw
lgtm
8 years, 10 months ago (2012-02-22 20:08:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@google.com/9416107/2002
8 years, 10 months ago (2012-02-22 21:04:40 UTC) #3
nfullagar
ptal - apparently some of the VM bots apparently don't have audio output, so RecommendSampleRate ...
8 years, 10 months ago (2012-02-22 22:58:19 UTC) #4
brettw
lgtm
8 years, 10 months ago (2012-02-24 04:46:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@google.com/9416107/1007
8 years, 10 months ago (2012-02-24 18:39:54 UTC) #6
commit-bot: I haz the power
8 years, 10 months ago (2012-02-24 20:13:48 UTC) #7
Change committed as 123531

Powered by Google App Engine
This is Rietveld 408576698