Make PPB_NetworkList_Private immutable.

ppapi/api/private/ppb_network_list_private.idl

Index: ppapi/api/private/ppb_network_list_private.idl
diff --git a/ppapi/api/private/ppb_network_list_private.idl b/ppapi/api/private/ppb_network_list_private.idl
index bbc8990f8ba0787ff4c5772d55374d2e483fb33b..f527cd528194e1067bb38c6d93eea2c1bbd21610 100644
--- a/ppapi/api/private/ppb_network_list_private.idl
+++ b/ppapi/api/private/ppb_network_list_private.idl
@@ -8,17 +8,10 @@
  */
 
 label Chrome {
-  M19 = 0.1
+  M19 = 0.2
 };
 
 /**
- * <code>PPB_NetworkListChanged_Callback</code> is a callback function
- * type that is used to receive notifications about changes in the
- * NetworkList.
- */
-typedef void PPB_NetworkListChanged_Callback([inout] mem_t user_data);
-
-/**
  * Type of a network interface.
  */
 [assert_size(4)]
@@ -56,22 +49,14 @@ enum PP_NetworkListState {
 };
 
 /**
- * The <code>PPB_NetworkList_Private</code> provides list of network
- * interfaces and associated IP addressed.
+ * The <code>PPB_NetworkList_Private</code> is used to represent a
+ * list of network interfaces and their configuration. The content of
+ * the list is immutable. Current networks configuration can be

[Wez, 2012/02/22 17:46:43]

nit: The current network configuration ...

[Sergey Ulanov, 2012/02/23 02:17:28]

Done.

+ * received using the <code>PPB_NetworkMonitor_Private</code>
+ * interface.
  */
 interface PPB_NetworkList_Private {
   /**
-   * Create() creates a new <code>NetworkList</code> object.
-   *
-   * @param[in] instance A <code>PP_Instance</code> identifying one instance
-   * of a module.
-   *
-   * @return A <code>PP_Resource</code> corresponding to a NetworkList if
-   * successful, 0 if the instance is invalid.
-   */
-  PP_Resource Create([in] PP_Instance instance);
-
-  /**
    * Determines if the specified <code>resource</code> is a
    * <code>NetworkList</code> object.
    *
@@ -84,29 +69,6 @@ interface PPB_NetworkList_Private {
   PP_Bool IsNetworkList([in] PP_Resource resource);
 
   /**
-   * Updates the list with the current state of the network interfaces
-   * in the system.
-   */
-  int32_t Update([in] PP_CompletionCallback callback);
-
-  /**
-   * Starts change notifications. The specified <code>callback</code>
-   * will be called every time the network list changes. Every time
-   * the callback is called the plugin must call Update() method to
-   * actually receive updated list.
-   */
-  int32_t StartNotifications([in] PP_Resource resource,
-                             [in] PPB_NetworkListChanged_Callback callback,
-                             [inout] mem_t user_data);
-
-  /**
-   * Stops change notifications. After this method is called the
-   * callback specified in <code>StartNotifications()</code> will not
-   * be called anymore.
-   */
-  int32_t StopNotifications([in] PP_Resource resource);
-
-  /**
    * @return Returns number of available network interfaces or 0 if
    * the list has never been updated.
    */
@@ -134,15 +96,21 @@ interface PPB_NetworkList_Private {
                                [in] uint32_t index);
 
   /**
-   * @return Returns <code>NetAddress</code> object that contains
-   * address of the specified <code>family</code> for the network
-   * interface with the specified <code>index</code>, or 0 if the
-   * address is not assigned.
-   */
-  PP_Resource GetIpAddress([in] PP_Resource resource,
-                           [in] uint32_t index,
-                           [in] PP_NetAddressFamily_Private family);
-
+   * Gets list of IP addresses for the network interface with the
+   * specified <code>index</code> and stores them in
+   * <code>addresses</code>. If the caller didn't allocate sufficient
+   * space to store all addresses, then only first <code>count</code>
+   * addresses are filled in.

[Wez, 2012/02/22 17:46:43]

How does the caller detect that condition?  Is the return-value -<N> in that
case, for example?

[Sergey Ulanov, 2012/02/23 02:17:28]

Caller can detect this by verifying that count is greater or equals the returned
value.

+   *
+   * @return Returns total number of IP addresses assigned to the
+   * network interface.

[brettw, 2012/02/22 17:26:39]

Can you say what the return value is on error?

[Sergey Ulanov, 2012/02/23 02:17:28]

Done.

+   */
+  int32_t GetIpAddresses(
+      [in] PP_Resource resource,
+      [in] uint32_t index,
+      [out, size_is(count)] PP_NetAddress_Private[] addresses,
+      [out] int32_t count);

[yzshen1, 2012/02/22 18:59:39]

This is an in/out parameter, right?

[Sergey Ulanov, 2012/02/23 02:17:28]

Actually this is supposed to be [in] - size of the buffer that the caller has
allocated.

+  
   /**
    * @return Returns display name for the network interface with the
    * specified <code>index</code>.