Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Unified Diff: skia/ext/bitmap_platform_device_android.cc

Issue 9416017: Optionally clear PlatformCanvas instances. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Address comments. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « skia/ext/bitmap_platform_device_android.h ('k') | skia/ext/bitmap_platform_device_linux.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/ext/bitmap_platform_device_android.cc
===================================================================
--- skia/ext/bitmap_platform_device_android.cc (revision 127021)
+++ skia/ext/bitmap_platform_device_android.cc (working copy)
@@ -21,21 +21,25 @@
return NULL;
}
+BitmapPlatformDevice* BitmapPlatformDevice::CreateAndClear(int width,
+ int height,
+ bool is_opaque) {
+ BitmapPlatformDevice* device = Create(width, height, is_opaque);
+ if (!is_opaque)
+ device->accessBitmap(true).eraseARGB(0, 0, 0, 0);
+ return device;
+}
+
BitmapPlatformDevice* BitmapPlatformDevice::Create(int width, int height,
bool is_opaque,
uint8_t* data) {
SkBitmap bitmap;
bitmap.setConfig(SkBitmap::kARGB_8888_Config, width, height);
- if (data) {
+ if (data)
bitmap.setPixels(data);
- } else {
- if (!bitmap.allocPixels())
- return NULL;
- // Follow the logic in SkCanvas::createDevice(), initialize the bitmap if it
- // is not opaque.
- if (!is_opaque)
- bitmap.eraseARGB(0, 0, 0, 0);
- }
+ else if (!bitmap.allocPixels())
+ return NULL;
+
bitmap.setIsOpaque(is_opaque);
return new BitmapPlatformDevice(bitmap);
}
« no previous file with comments | « skia/ext/bitmap_platform_device_android.h ('k') | skia/ext/bitmap_platform_device_linux.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698