Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3848)

Unified Diff: chrome/common/mac/app_mode_common.h

Issue 9416012: Mac: Generate App Mode Loader bundle + cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Tweak Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/mac/app_mode_common.h
diff --git a/chrome/common/mac/app_mode_common.h b/chrome/common/mac/app_mode_common.h
index 5267cd495c35d29127089746c98bce1c41cd82be..cb9f1825e836a7c08406cc7560f3d5dca43a171b 100644
--- a/chrome/common/mac/app_mode_common.h
+++ b/chrome/common/mac/app_mode_common.h
@@ -20,10 +20,6 @@ namespace app_mode {
// app mode launcher bundle's Info.plist.
extern NSString* const kBrowserBundleIDKey;
-// The key under which to record the path to the (user-visible) application
-// bundle; this key is recorded under the ID given by |kAppPrefsID|.
-extern NSString* const kLastRunAppBundlePathPrefsKey;
-
// Key for the shortcut ID.
extern NSString* const kCrAppModeShortcutIDKey;
@@ -36,6 +32,14 @@ extern NSString* const kCrAppModeShortcutNameKey;
// Key for the app's URL.
extern NSString* const kCrAppModeShortcutURLKey;
+// When the Chrome browser is run, it stores it's location in the defaults
+// system using this key.
+extern NSString* const kLastRunAppBundlePathPrefsKey;
+
+// Placeholder used in the Info.plist, meant to be replaced by the extension
+// shortcut ID.
+extern NSString* const kShortcutIdPlaceholder;
+
// Current major/minor version numbers of |ChromeAppModeInfo| (defined below).
const unsigned kCurrentChromeAppModeInfoMajorVersion = 1;
const unsigned kCurrentChromeAppModeInfoMinorVersion = 0;
@@ -62,9 +66,12 @@ struct ChromeAppModeInfo {
// Versioned path to the browser which is being loaded.
FilePath chrome_versioned_path; // Required: v1.0
+ // Path to Chrome app bundle.
+ FilePath chrome_outer_bundle_path; // Required: v1.0
+
// Information about the App Mode shortcut:
- // Path to the App Mode Loader application bundle originally run.
+ // Path to the App Mode Loader application bundle that launched the process.
FilePath app_mode_bundle_path; // Optional: v1.0
// Short ID string, preferably derived from |app_mode_short_name|. Should be
@@ -78,7 +85,7 @@ struct ChromeAppModeInfo {
string16 app_mode_name; // Optional: v1.0
// URL for the shortcut. Must be a valid URL.
- std::string app_mode_url; // Required: v1.0
+ std::string app_mode_url; // Optional: v1.0
};
} // namespace app_mode

Powered by Google App Engine
This is Rietveld 408576698