Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: chrome/browser/web_applications/web_app_mac.h

Issue 9416012: Mac: Generate App Mode Loader bundle + cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix gyp dependencies Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome_main_app_mode_mac.mm ('k') | chrome/browser/web_applications/web_app_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_applications/web_app_mac.h
diff --git a/chrome/browser/web_applications/web_app_mac.h b/chrome/browser/web_applications/web_app_mac.h
index 261b9d724a4f00e48b7dc11546a6325f8aae60bd..061ba87d2aea9f0fbf48aa7b3517bb6a73274603 100644
--- a/chrome/browser/web_applications/web_app_mac.h
+++ b/chrome/browser/web_applications/web_app_mac.h
@@ -7,8 +7,12 @@
#pragma once
#include "base/file_path.h"
+#include "base/string16.h"
#include "chrome/browser/shell_integration.h"
+@class NSDictionary;
+@class NSString;
+
namespace web_app {
// Creates a shortcut for a web application. The shortcut is a stub app
@@ -16,11 +20,14 @@ namespace web_app {
class WebAppShortcutCreator {
public:
// Creates a new shortcut based on information in |shortcut_info|.
+ // |chrome_bundle_id| is the CFBundleIdentifier of the Chrome browser bundle.
explicit WebAppShortcutCreator(
sail 2012/02/20 21:17:49 This doesn't need to be explicit anymore.
- const ShellIntegration::ShortcutInfo& shortcut_info);
+ const ShellIntegration::ShortcutInfo& shortcut_info,
+ const string16& chrome_bundle_id);
virtual ~WebAppShortcutCreator();
- // Creates a shortcut.
+ // Copies the app launcher template into place and fills in all relevant
+ // information.
bool CreateShortcut();
protected:
@@ -37,8 +44,16 @@ class WebAppShortcutCreator {
bool UpdateIcon(const FilePath& app_path) const;
private:
+ // Returns the bundle identifier to use for this app bundle.
+ // |plist| is a dictionary containg a copy of the template plist file to
+ // be used for creating the app bundle.
+ NSString* GetBundleIdentifier(NSDictionary* plist) const;
+
// Information about the app.
ShellIntegration::ShortcutInfo info_;
+
+ // The CFBundleIdentifier of the Chrome browser bundle.
+ string16 chrome_bundle_id_;
};
} // namespace web_app
« no previous file with comments | « chrome/app/chrome_main_app_mode_mac.mm ('k') | chrome/browser/web_applications/web_app_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698