Mac: Generate App Mode Loader bundle + cleanup

chrome/browser/web_applications/web_app_mac.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_MAC_H_
 #define CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_MAC_H_
 #pragma once
 
 #include "base/file_path.h"
 #include "chrome/browser/shell_integration.h"
 
+@class NSString;
+
 namespace web_app {
 
 // Creates a shortcut for a web application. The shortcut is a stub app
 // that simply loads the browser framework and runs the given app.
 class WebAppShortcutCreator {
  public:
   // Creates a new shortcut based on information in |shortcut_info|.
   explicit WebAppShortcutCreator(
       const ShellIntegration::ShortcutInfo& shortcut_info);
   virtual ~WebAppShortcutCreator();
 
-  // Creates a shortcut.
-  bool CreateShortcut();
+  // Copies the app launcher template into place and fills in all relevant
+  // information.
+  // |chrome_bundle_id| - CFBundleIdentifier of the Chrome browser bundle.
+  bool CreateShortcut(NSString* chrome_bundle_id);

[sail, 2012/02/17 16:42:09]

Instead of passing the bundle ID to create shortcut it would be better to pass
it to the constructor and save it in a member variable. If you do that it would
also be better to use a string16 instead of a Objective-C object.

[jeremy, 2012/02/19 14:36:41]

Done.

 
  protected:
   // Returns a path to the app loader.
   FilePath GetAppLoaderPath() const;
 
   // Returns a path to the destination where the app should be written to.
   virtual FilePath GetDestinationPath(const FilePath& app_file_name) const;
 
   // Updates the plist inside |app_path| with information about the app.
-  bool UpdatePlist(const FilePath& app_path) const;
+  bool UpdatePlist(const FilePath& app_path, NSString* chrome_bundle_id) const;
 
   // Updates the icon for the shortcut.
   bool UpdateIcon(const FilePath& app_path) const;
 
  private:
   // Information about the app.
   ShellIntegration::ShortcutInfo info_;
 };
 
 }  // namespace web_app
 
 #endif  // CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_MAC_H_