Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: chrome/browser/transport_security_persister.h

Issue 9415040: Refactor TransportSecurityState. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TransportSecurityState maintains an in memory database containing the 5 // TransportSecurityState maintains an in memory database containing the
6 // list of hosts that currently have transport security enabled. This 6 // list of hosts that currently have transport security enabled. This
7 // singleton object deals with writing that data out to disk as needed and 7 // singleton object deals with writing that data out to disk as needed and
8 // loading it at startup. 8 // loading it at startup.
9 9
10 // At startup we need to load the transport security state from the 10 // At startup we need to load the transport security state from the
11 // disk. For the moment, we don't want to delay startup for this load, so we 11 // disk. For the moment, we don't want to delay startup for this load, so we
12 // let the TransportSecurityState run for a while without being loaded. 12 // let the TransportSecurityState run for a while without being loaded.
13 // This means that it's possible for pages opened very quickly not to get the 13 // This means that it's possible for pages opened very quickly not to get the
14 // correct transport security information. 14 // correct transport security information.
15 // 15 //
16 // To load the state, we schedule a Task on the file thread which loads, 16 // To load the state, we schedule a Task on the file thread which loads,
17 // deserialises and configures the TransportSecurityState. 17 // deserializes and configures the TransportSecurityState.
18 // 18 //
19 // The TransportSecurityState object supports running a callback function 19 // The TransportSecurityState object supports running a callback function
20 // when it changes. This object registers the callback, pointing at itself. 20 // when it changes. This object registers the callback, pointing at itself.
21 // 21 //
22 // TransportSecurityState calls... 22 // TransportSecurityState calls...
23 // TransportSecurityPersister::StateIsDirty 23 // TransportSecurityPersister::StateIsDirty
24 // since the callback isn't allowed to block or reenter, we schedule a Task 24 // since the callback isn't allowed to block or reenter, we schedule a Task
25 // on the file thread after some small amount of time 25 // on the file thread after some small amount of time
26 // 26 //
27 // ... 27 // ...
28 // 28 //
29 // TransportSecurityPersister::SerialiseState 29 // TransportSecurityPersister::SerializeState
30 // copies the current state of the TransportSecurityState, serialises 30 // copies the current state of the TransportSecurityState, serializes
31 // and writes to disk. 31 // and writes to disk.
32 32
33 #ifndef CHROME_BROWSER_TRANSPORT_SECURITY_PERSISTER_H_ 33 #ifndef CHROME_BROWSER_TRANSPORT_SECURITY_PERSISTER_H_
34 #define CHROME_BROWSER_TRANSPORT_SECURITY_PERSISTER_H_ 34 #define CHROME_BROWSER_TRANSPORT_SECURITY_PERSISTER_H_
35 #pragma once 35 #pragma once
36 36
37 #include <string> 37 #include <string>
38 38
39 #include "base/file_path.h" 39 #include "base/file_path.h"
40 #include "base/memory/weak_ptr.h" 40 #include "base/memory/weak_ptr.h"
(...skipping 13 matching lines...) Expand all
54 54
55 // Called by the TransportSecurityState when it changes its state. 55 // Called by the TransportSecurityState when it changes its state.
56 virtual void StateIsDirty(net::TransportSecurityState*) OVERRIDE; 56 virtual void StateIsDirty(net::TransportSecurityState*) OVERRIDE;
57 57
58 // ImportantFileWriter::DataSerializer: 58 // ImportantFileWriter::DataSerializer:
59 virtual bool SerializeData(std::string* data) OVERRIDE; 59 virtual bool SerializeData(std::string* data) OVERRIDE;
60 60
61 private: 61 private:
62 class Loader; 62 class Loader;
63 63
64 // Serializes |transport_security_state_| into |*output|. Returns true if
65 // all DomainStates were serialized correctly.
66 //
67 // The serialization format is JSON; the JSON represents a dictionary of
68 // host:DomainState pairs (host is a string). The DomainState is
69 // represented as a dictionary containing the following keys and value
70 // types (not all keys will always be present):
71 //
72 // "include_subdomains": true|false
73 // "created": double
74 // "expiry": double
75 // "dynamic_spki_hashes_expiry": double
76 // "mode": "default"|"force-https"
77 // legacy value synonyms "strict" = "force-https"
78 // "pinning-only" = "default"
79 // legacy value "spdy-only" is unused and ignored
80 // "static_spki_hashes": list of strings
81 // legacy key synonym "preloaded_spki_hashes"
82 // "bad_static_spki_hashes": list of strings
83 // legacy key synonym "bad_preloaded_spki_hashes"
84 // "dynamic_spki_hashes": list of strings
85 //
86 // The keys are
87 // SHA256(net::TransportSecurityState::CanonicalizeHost(domain)). The
88 // reason for hashing them is so that the stored state does not trivially
89 // reveal a user's browsing history to an attacker reading the serialized
90 // state on disk.
91 bool Serialize(std::string* output) const;
92
93 // Populates |state| from the JSON string |serialized|. Returns true if
94 // all entries were parsed and deserialized correctly.
95 //
96 // Sets |*dirty| to true if the new state differs from the persisted
97 // state; false otherwise.
98 static bool Deserialize(const std::string& serialized,
99 bool* dirty,
100 net::TransportSecurityState* state);
101
102 // Clears any existing non-static entries, and then re-populates |state|
103 // by invoking |Deserialize|.
104 //
105 // Sets |*dirty| to true if the new state differs from the persisted
106 // state; false otherwise.
107 bool LoadEntries(const std::string& serialized,
108 bool* dirty,
109 net::TransportSecurityState* state);
110
64 void CompleteLoad(const std::string& state); 111 void CompleteLoad(const std::string& state);
65 112
66 net::TransportSecurityState* transport_security_state_; 113 net::TransportSecurityState* transport_security_state_;
67 114
68 // Helper for safely writing the data. 115 // Helper for safely writing the data.
69 ImportantFileWriter writer_; 116 ImportantFileWriter writer_;
70 117
71 // Whether or not we're in read-only mode. 118 // Whether or not we're in read-only mode.
72 const bool readonly_; 119 const bool readonly_;
73 120
74 base::WeakPtrFactory<TransportSecurityPersister> weak_ptr_factory_; 121 base::WeakPtrFactory<TransportSecurityPersister> weak_ptr_factory_;
75 122
76 DISALLOW_COPY_AND_ASSIGN(TransportSecurityPersister); 123 DISALLOW_COPY_AND_ASSIGN(TransportSecurityPersister);
77 }; 124 };
78 125
79 #endif // CHROME_BROWSER_TRANSPORT_SECURITY_PERSISTER_H_ 126 #endif // CHROME_BROWSER_TRANSPORT_SECURITY_PERSISTER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698