Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 9415039: Add base::StaticAtomicSequenceNumber. (Closed)

Created:
8 years, 10 months ago by Philippe
Modified:
8 years, 9 months ago
CC:
chromium-reviews, sadrul, jam, mihaip+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add base::StaticAtomicSequenceNumber. This patch also replaces the global AtomicSequenceNumber variables with StaticAtomicSequenceNumber in order to remove static initializers. BUG=94925 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126376

Patch Set 1 #

Patch Set 2 : Fix build error #

Patch Set 3 : Rename to StaticAtomicSequenceNumber #

Patch Set 4 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -22 lines) Patch
M base/atomic_sequence_num.h View 1 2 1 chunk +35 lines, -5 lines 0 comments Download
M base/lazy_instance_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M base/message_loop_proxy_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/cfproxy_support.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_message.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M media/base/media_log.cc View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M printing/print_settings.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/quota/mock_storage_client.cc View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Philippe
8 years, 9 months ago (2012-03-05 16:54:16 UTC) #1
acolwell GONE FROM CHROMIUM
Changes in media/ LGTM
8 years, 9 months ago (2012-03-05 17:09:44 UTC) #2
erikwright (departed)
cfproxy_support LGTM.
8 years, 9 months ago (2012-03-05 17:50:41 UTC) #3
agl
ipc/ LGTM
8 years, 9 months ago (2012-03-05 17:52:17 UTC) #4
kinuko
webkit/quota LGTM
8 years, 9 months ago (2012-03-05 18:15:23 UTC) #5
Lei Zhang
printing/ LGTM
8 years, 9 months ago (2012-03-05 20:13:51 UTC) #6
jstritar
extensions/ LGTM
8 years, 9 months ago (2012-03-05 20:18:56 UTC) #7
Philippe
On 2012/03/05 20:18:56, jstritar wrote: > extensions/ LGTM Ping :)
8 years, 9 months ago (2012-03-09 13:49:15 UTC) #8
Lei Zhang
On 2012/03/09 13:49:15, Philippe wrote: > On 2012/03/05 20:18:56, jstritar wrote: > > extensions/ LGTM ...
8 years, 9 months ago (2012-03-09 20:27:55 UTC) #9
Philippe
On 2012/03/09 20:27:55, Lei Zhang wrote: > On 2012/03/09 13:49:15, Philippe wrote: > > On ...
8 years, 9 months ago (2012-03-12 11:11:19 UTC) #10
brettw
base LGTM
8 years, 9 months ago (2012-03-12 17:50:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/9415039/16001
8 years, 9 months ago (2012-03-12 17:54:16 UTC) #12
commit-bot: I haz the power
Try job failure for 9415039-16001 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-12 18:49:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/9415039/16001
8 years, 9 months ago (2012-03-12 19:06:57 UTC) #14
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 9 months ago (2012-03-12 23:53:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/9415039/16001
8 years, 9 months ago (2012-03-13 09:40:20 UTC) #16
commit-bot: I haz the power
8 years, 9 months ago (2012-03-13 12:07:22 UTC) #17
Change committed as 126376

Powered by Google App Engine
This is Rietveld 408576698