Use scoped_ptr<> to store ConfirmBubbleModel.

chrome/browser/ui/cocoa/confirm_bubble_controller.h

Index: chrome/browser/ui/cocoa/confirm_bubble_controller.h
===================================================================
--- chrome/browser/ui/cocoa/confirm_bubble_controller.h	(revision 122794)
+++ chrome/browser/ui/cocoa/confirm_bubble_controller.h	(working copy)
@@ -9,6 +9,7 @@
 #import <Cocoa/Cocoa.h>
 
 #import "base/mac/cocoa_protocols.h"
+#import "base/memory/scoped_ptr.h"

[Mark Mentovai, 2012/02/21 20:00:48]

You don’t #import this, you #include it.

Use #import for Objective-C[++] headers. scoped_ptr.h is a straight C++ header.
Use #include.

[Hironori Bono, 2012/02/22 07:22:50]

Done. Thanks for pointing it out. I copied the previous line and pasted it
without changing import to include.

 
 class ConfirmBubbleModel;
 
@@ -21,10 +22,11 @@
  @private
   NSView* parent_;  // weak
   CGPoint origin_;
-  ConfirmBubbleModel* model_;  // weak
+  scoped_ptr<ConfirmBubbleModel> model_;
 }
 
-// Creates a ConfirmBubbleController object.
+// Creates a ConfirmBubbleController object. When we successfully create a

[Mark Mentovai, 2012/02/21 20:00:48]

Avoid use of “we” in comments. It’s meaningless and ambiguous. Who are “we?” The
ConfirmBubbleController object takes ownership of the passed-in
ConfirmBubbleModel, “we” don’t.

[Hironori Bono, 2012/02/22 07:22:50]

Done. Thanks for correcting my English.

+// controller, it takes the ownership of the given ConfirmBubbleModel.
 - (id)initWithParent:(NSView*)parent
               origin:(CGPoint)origin
                model:(ConfirmBubbleModel*)model;