Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/cocoa/confirm_bubble_controller.h

Issue 9414039: Use scoped_ptr<> to store ConfirmBubbleModel. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/confirm_bubble_controller.mm » ('j') | chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/confirm_bubble_controller.h
===================================================================
--- chrome/browser/ui/cocoa/confirm_bubble_controller.h (revision 122469)
+++ chrome/browser/ui/cocoa/confirm_bubble_controller.h (working copy)
@@ -9,6 +9,7 @@
#import <Cocoa/Cocoa.h>
#import "base/mac/cocoa_protocols.h"
+#import "base/memory/scoped_ptr.h"
class ConfirmBubbleModel;
@@ -21,7 +22,7 @@
@private
NSView* parent_; // weak
CGPoint origin_;
- ConfirmBubbleModel* model_; // weak
+ scoped_ptr<ConfirmBubbleModel> model_;
}
// Creates a ConfirmBubbleController object.
Robert Sesek 2012/02/17 15:24:25 Adjust comment to say that it takes ownership of |
Hironori Bono 2012/02/22 07:22:50 Done.
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/confirm_bubble_controller.mm » ('j') | chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698