Use scoped_ptr<> to store ConfirmBubbleModel.

Use scoped_ptr<> to store ConfirmBubbleModel.
This change uses scoped_ptr<ConfirmBubbleModel> instead of a raw pointer for consistency with GTK and Views.

BUG=none
TEST=run ConfirmBubbleControllerTests on valgrind.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123007

[Hironori Bono, 2012-02-17 11:34:52]

Greetings Mark and Robert,

Thanks for your help in advance.
When I ported ConfirmBubbleModel to GTK, I changed to use scoped_ptr<> on GTK
and Views. I notice this change causes a leak on Mac. Can we use scoped_ptr<>
also on Mac?

Regards,

Hironori Bono

[Robert Sesek, 2012-02-17 15:24:25]

lgtm with two nits

http://codereview.chromium.org/9414039/diff/1/chrome/browser/ui/cocoa/confirm...
File chrome/browser/ui/cocoa/confirm_bubble_controller.h (right):

http://codereview.chromium.org/9414039/diff/1/chrome/browser/ui/cocoa/confirm...
chrome/browser/ui/cocoa/confirm_bubble_controller.h:28: // Creates a
ConfirmBubbleController object.
Adjust comment to say that it takes ownership of |model|.

http://codereview.chromium.org/9414039/diff/1/chrome/browser/ui/cocoa/confirm...
File chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm (right):

http://codereview.chromium.org/9414039/diff/1/chrome/browser/ui/cocoa/confirm...
chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm:105: model_ = new
TestConfirmBubbleModel(&model_deleted_,
Comment: // Owned by the controller.

[Mark Mentovai, 2012-02-21 20:00:48]

LGTM with these comments addressed.

http://codereview.chromium.org/9414039/diff/7009/chrome/browser/ui/cocoa/conf...
File chrome/browser/ui/cocoa/confirm_bubble_controller.h (right):

http://codereview.chromium.org/9414039/diff/7009/chrome/browser/ui/cocoa/conf...
chrome/browser/ui/cocoa/confirm_bubble_controller.h:12: #import
"base/memory/scoped_ptr.h"
You don’t #import this, you #include it.

Use #import for Objective-C[++] headers. scoped_ptr.h is a straight C++ header.
Use #include.

http://codereview.chromium.org/9414039/diff/7009/chrome/browser/ui/cocoa/conf...
chrome/browser/ui/cocoa/confirm_bubble_controller.h:28: // Creates a
ConfirmBubbleController object. When we successfully create a
Avoid use of “we” in comments. It’s meaningless and ambiguous. Who are “we?” The
ConfirmBubbleController object takes ownership of the passed-in
ConfirmBubbleModel, “we” don’t.

[Hironori Bono, 2012-02-22 07:22:50]

Greetings Mark and Robert,

Many thanks for your review and comments. I have applied them and landed the
updated one.

Regards,

Hironori Bono

http://codereview.chromium.org/9414039/diff/1/chrome/browser/ui/cocoa/confirm...
File chrome/browser/ui/cocoa/confirm_bubble_controller.h (right):

http://codereview.chromium.org/9414039/diff/1/chrome/browser/ui/cocoa/confirm...
chrome/browser/ui/cocoa/confirm_bubble_controller.h:28: // Creates a
ConfirmBubbleController object.
On 2012/02/17 15:24:25, rsesek wrote:
> Adjust comment to say that it takes ownership of |model|.

Done.

http://codereview.chromium.org/9414039/diff/1/chrome/browser/ui/cocoa/confirm...
File chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm (right):

http://codereview.chromium.org/9414039/diff/1/chrome/browser/ui/cocoa/confirm...
chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm:105: model_ = new
TestConfirmBubbleModel(&model_deleted_,
On 2012/02/17 15:24:25, rsesek wrote:
> Comment: // Owned by the controller.

Done.

http://codereview.chromium.org/9414039/diff/7009/chrome/browser/ui/cocoa/conf...
File chrome/browser/ui/cocoa/confirm_bubble_controller.h (right):

http://codereview.chromium.org/9414039/diff/7009/chrome/browser/ui/cocoa/conf...
chrome/browser/ui/cocoa/confirm_bubble_controller.h:12: #import
"base/memory/scoped_ptr.h"
On 2012/02/21 20:00:48, Mark Mentovai wrote:
> You don’t #import this, you #include it.
> 
> Use #import for Objective-C[++] headers. scoped_ptr.h is a straight C++
header.
> Use #include.

Done. Thanks for pointing it out. I copied the previous line and pasted it
without changing import to include.

http://codereview.chromium.org/9414039/diff/7009/chrome/browser/ui/cocoa/conf...
chrome/browser/ui/cocoa/confirm_bubble_controller.h:28: // Creates a
ConfirmBubbleController object. When we successfully create a
On 2012/02/21 20:00:48, Mark Mentovai wrote:
> Avoid use of “we” in comments. It’s meaningless and ambiguous. Who are “we?”
The
> ConfirmBubbleController object takes ownership of the passed-in
> ConfirmBubbleModel, “we” don’t.

Done. Thanks for correcting my English.

[commit-bot: I haz the power, 2012-02-22 07:22:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hbono@chromium.org/9414039/19001

[commit-bot: I haz the power, 2012-02-22 09:32:25]

Change committed as 123007