Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 9414022: Linux: Remove references to '-nopie' now that it's fixed in cros and doesn't exist on Pangolin. (Closed)

Created:
8 years, 10 months ago by Elliot Glaysher
Modified:
8 years, 10 months ago
Reviewers:
rkc, cmtice, Evan Martin
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: Remove references to '-nopie' now that it's fixed in cros and doesn't exist on Pangolin. BUG=cros:15266, 79722 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M build/common.gypi View 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Elliot Glaysher
Hi, I'm working on getting chrome compiling on Ubuntu Precise Pangolin (12.04) since we're all ...
8 years, 10 months ago (2012-02-16 21:11:57 UTC) #1
rkc
Yep. LGTM. On 2012/02/16 21:11:57, Elliot Glaysher wrote: > Hi, I'm working on getting chrome ...
8 years, 10 months ago (2012-02-16 21:13:30 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 10 months ago (2012-02-16 21:16:37 UTC) #3
Elliot Glaysher
+evan for commitable lgtm
8 years, 10 months ago (2012-02-16 21:17:18 UTC) #4
rkc
On 2012/02/16 21:17:18, Elliot Glaysher wrote: > +evan for commitable lgtm Hmm, after 2 years ...
8 years, 10 months ago (2012-02-16 21:22:00 UTC) #5
Evan Martin
LGTM
8 years, 10 months ago (2012-02-16 21:22:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9414022/1
8 years, 10 months ago (2012-02-16 21:26:02 UTC) #7
commit-bot: I haz the power
8 years, 10 months ago (2012-02-16 23:26:06 UTC) #8
Change committed as 122387

Powered by Google App Engine
This is Rietveld 408576698