Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 9408: Removed some unsafe uses of StringShape.... (Closed)

Created:
12 years, 1 month ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Removed some unsafe uses of StringShape. Simplified some uses of StringShape. Removed unused function SlicedStringFlatten. Committed: http://code.google.com/p/v8/source/detail?r=695

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -75 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/conversions.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/factory.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/handles.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/heap.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M src/jsregexp.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/log.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/objects.cc View 4 chunks +4 lines, -20 lines 0 comments Download
M src/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 8 chunks +12 lines, -16 lines 0 comments Download
M test/cctest/test-strings.cc View 3 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
12 years, 1 month ago (2008-11-05 09:42:01 UTC) #1
Mads Ager (chromium)
12 years, 1 month ago (2008-11-05 09:51:53 UTC) #2
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698