Issue 9408: Removed some unsafe uses of StringShape....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9408: Removed some unsafe uses of StringShape.... (Closed)

Created:
12 years, 1 month ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Removed some unsafe uses of StringShape. Simplified some uses of StringShape. Removed unused function SlicedStringFlatten. Committed: http://code.google.com/p/v8/source/detail?r=695

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -75 lines)			Patch
M	src/compiler.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/conversions.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/factory.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/factory.cc	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	src/handles.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.h	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	src/heap.cc	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	src/jsregexp.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/log.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/objects.h	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	src/objects.cc	View	4 chunks	+4 lines, -20 lines	0 comments	Download
M	src/parser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View	8 chunks	+12 lines, -16 lines	0 comments	Download
M	test/cctest/test-strings.cc	View	3 chunks	+2 lines, -7 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM, thanks!