Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 9404029: Changes for 'C' version of documentation files needed to generate new DevSite reference. (Closed)

Created:
8 years, 10 months ago by jond
Modified:
8 years, 10 months ago
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Changes for 'C' version of documentation files needed to generate new DevSite reference. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122577

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -31 lines) Patch
M ppapi/c/documentation/footer.html View 1 1 chunk +4 lines, -2 lines 0 comments Download
M ppapi/c/documentation/header.html View 1 1 chunk +10 lines, -13 lines 0 comments Download
M ppapi/c/documentation/removefilesC.sh View 1 2 chunks +15 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jond
These are the changes I have yet to check in for 'c' - specific files ...
8 years, 10 months ago (2012-02-15 23:03:35 UTC) #1
cstefansen
Don't see any major issues, but I'm not sufficiently familiar with the doc generation system ...
8 years, 10 months ago (2012-02-15 23:45:07 UTC) #2
jond
http://codereview.chromium.org/9404029/diff/1/ppapi/c/documentation/footer.html File ppapi/c/documentation/footer.html (right): http://codereview.chromium.org/9404029/diff/1/ppapi/c/documentation/footer.html#newcode1 ppapi/c/documentation/footer.html:1: </div> <!-- id="doxygen-ref" --> On 2012/02/15 23:45:07, cstefansen wrote: ...
8 years, 10 months ago (2012-02-16 18:06:07 UTC) #3
cstefansen
LGTM (given the Doxygen oddness). On 2012/02/16 18:06:07, jond wrote: > http://codereview.chromium.org/9404029/diff/1/ppapi/c/documentation/footer.html > File ppapi/c/documentation/footer.html ...
8 years, 10 months ago (2012-02-16 22:05:52 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 10 months ago (2012-02-17 16:09:27 UTC) #5
jond
Can you rubber stamp LGTM?
8 years, 10 months ago (2012-02-17 16:37:46 UTC) #6
dmichael (off chromium)
lgtm
8 years, 10 months ago (2012-02-17 16:40:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jond@google.com/9404029/6001
8 years, 10 months ago (2012-02-17 19:21:56 UTC) #8
commit-bot: I haz the power
8 years, 10 months ago (2012-02-17 20:50:58 UTC) #9
Change committed as 122577

Powered by Google App Engine
This is Rietveld 408576698