Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: chrome/browser/rlz/rlz.h

Issue 9404021: rlz: Remove #include <windows.h> (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/rlz/rlz.cc » ('j') | chrome/browser/rlz/rlz.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/rlz/rlz.h
diff --git a/chrome/browser/rlz/rlz.h b/chrome/browser/rlz/rlz.h
index 7145085d7e7ef5a8fad051214967ce6b0b19fb33..978b8502330605ae3e8886954107a24ef220904f 100644
--- a/chrome/browser/rlz/rlz.h
+++ b/chrome/browser/rlz/rlz.h
@@ -65,10 +65,6 @@ class RLZTracker : public content::NotificationObserver {
RLZTracker();
~RLZTracker();
- // Thread function entry point, see ScheduleFinancialPing(). Assumes argument
- // is a pointer to an RLZTracker.
- static void _cdecl PingNow(void* tracker);
-
// Performs initialization of RLZ tracker that is purposefully delayed so
// that it does not interfere with chrome startup time.
virtual void DelayedInit();
@@ -84,6 +80,11 @@ class RLZTracker : public content::NotificationObserver {
tracker_ = tracker;
}
+ // Sends the financial ping to the RLZ servers and invalidates the RLZ string
+ // cache since the response from the RLZ server may have changed then.
+ // Protected so that its accessible from tests.
+ void PingNowImpl();
+
private:
friend struct DefaultSingletonTraits<RLZTracker>;
friend class base::RefCountedThreadSafe<RLZTracker>;
@@ -109,10 +110,6 @@ class RLZTracker : public content::NotificationObserver {
// virtual to allow tests to override how the scheduling is done.
virtual bool ScheduleGetAccessPointRlz(rlz_lib::AccessPoint point);
- // Sends the financial ping to the RLZ servers and invalidates the RLZ string
- // cache since the response from the RLZ server may have changed then.
- void PingNowImpl();
-
// Sends the financial ping to the RLZ servers. This method is virtual to
// allow tests to override.
virtual bool SendFinancialPing(const std::string& brand,
« no previous file with comments | « no previous file | chrome/browser/rlz/rlz.cc » ('j') | chrome/browser/rlz/rlz.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698