rlz: Remove #include <windows.h>

chrome/browser/rlz/rlz.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This code glues the RLZ library DLL with Chrome. It allows Chrome to work
 // with or without the DLL being present. If the DLL is not present the
 // functions do nothing and just return false.
 
 #include "chrome/browser/rlz/rlz.h"
 
-#include <windows.h>
-#include <process.h>
-
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/file_path.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "base/synchronization/lock.h"
 #include "base/threading/thread.h"
@@ skipping 200 matching lines @@
     schedule_ping = true;
   }
 
   already_ran_ = true;
 
   if (schedule_ping)
     ScheduleFinancialPing();
 }
 
 void RLZTracker::ScheduleFinancialPing() {
-  // Investigate why _beginthread() is used here, and not chrome's threading
-  // API.  Tracked in bug http://crbug.com/106213
-  _beginthread(PingNow, 0, this);
-}
-
-// static
-void _cdecl RLZTracker::PingNow(void* arg) {
-  RLZTracker* tracker = reinterpret_cast<RLZTracker*>(arg);
-  tracker->PingNowImpl();
+  // TODO(thakis): Once akalin's TaskRunner around PostDelayedTask() is done,
+  // use that instead of the file thread.
+  BrowserThread::PostTask(
+      BrowserThread::FILE,
+      FROM_HERE,
+      base::Bind(&RLZTracker::PingNowImpl, base::Unretained(this)));

[akalin, 2012/02/16 01:03:36]

does PingNowImpl actually depend on instance variables?  If so, you probably
want a weak ptr here.  If not, maybe PingNowImpl should be static

[Nico, 2012/02/16 01:11:47]

Yes, it seems to look at cache_lock_. The instance lives in a singleton, so it 
shouldn't go away (and the class isn't SupportsWeakPtr<>).

 }
 
 void RLZTracker::PingNowImpl() {
   // This is the entry point of a background thread, so I/O is allowed.

[akalin, 2012/02/16 01:03:36]

update this comment, although is the allow_io still needed?

[Nico, 2012/02/16 01:11:47]

Guess not. Done.

   base::ThreadRestrictions::ScopedAllowIO allow_io;
 
   string16 lang;
   GoogleUpdateSettings::GetLanguage(&lang);
   if (lang.empty())
     lang = L"en";
   string16 referral;
   GoogleUpdateSettings::GetReferral(&referral);
 
   std::string brand;
   if (google_util::GetBrand(&brand) && !IsBrandOrganic(brand) &&
       SendFinancialPing(brand, lang, referral)) {

[akalin, 2012/02/16 01:08:25]

does this do network IO or file IO?  If it's network IO, it probably belongs on
the IO thread instead

[Nico, 2012/02/16 01:13:31]

I believe this accesses the registry behind the scenes which does hit the disk.

     GoogleUpdateSettings::ClearReferral();
 
     {
       base::AutoLock lock(cache_lock_);
       rlz_cache_.clear();
     }
 
     // Prime the RLZ cache for the access points we are interested in.
     GetAccessPointRlz(rlz_lib::CHROME_OMNIBOX, NULL);
     GetAccessPointRlz(rlz_lib::CHROME_HOME_PAGE, NULL);
@@ skipping 133 matching lines @@
       base::Bind(base::IgnoreResult(&RLZTracker::GetAccessPointRlz), point,
                  not_used));
   return true;
 }
 
 // static
 void RLZTracker::CleanupRlz() {
   GetInstance()->rlz_cache_.clear();
   GetInstance()->registrar_.RemoveAll();
 }