Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 9404016: GTK: Address GSEALs in TaskManager. (Closed)

Created:
8 years, 10 months ago by Elliot Glaysher
Modified:
8 years, 10 months ago
Reviewers:
Mike Mammarella
CC:
chromium-reviews, yoshiki+watch_chromium.org
Visibility:
Public.

Description

GTK: Address GSEALs in TaskManager. BUG=79722 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122198

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -48 lines) Patch
M chrome/browser/ui/gtk/task_manager_gtk.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/task_manager_gtk.cc View 4 chunks +1 line, -45 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Elliot Glaysher
So the task manager reaches into the implementation of GtkTreeViewColumn to fiddle with implementation details. ...
8 years, 10 months ago (2012-02-15 19:21:07 UTC) #1
Mike Mammarella
On 2012/02/15 19:21:07, Elliot Glaysher wrote: > So the task manager reaches into the implementation ...
8 years, 10 months ago (2012-02-15 21:34:36 UTC) #2
Mike Mammarella
LGTM! Indeed this hack has outlived its usefulness and it now works better without.
8 years, 10 months ago (2012-02-15 22:46:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9404016/1
8 years, 10 months ago (2012-02-15 22:49:04 UTC) #4
commit-bot: I haz the power
8 years, 10 months ago (2012-02-16 00:21:24 UTC) #5
Change committed as 122198

Powered by Google App Engine
This is Rietveld 408576698